feat: 1325 add global and per feed configurationintegrate feeds download#1363
Merged
davidgamez merged 17 commits intoSep 25, 2025
Merged
Conversation
qcdyx
marked this pull request as ready for review
September 23, 2025 15:00
davidgamez
reviewed
Sep 24, 2025
davidgamez
left a comment
davidgamez
left a comment
Member
There was a problem hiding this comment.
Great work. Before merging we must address #1061 otherwise SQL script will fail.
Comment on lines
+151
to
+161
| headers = get_config_value( | ||
| namespace="feed_download", key="http_headers", feed_id=feed_id | ||
| ) | ||
| if headers is None: | ||
| headers = { | ||
| "User-Agent": "Mozilla/5.0 (Linux; Android 6.0; Nexus 5 Build/MRA58N) " | ||
| "AppleWebKit/537.36 (KHTML, like Gecko) " | ||
| "Chrome/126.0.0.0 Mobile Safari/537.36", | ||
| "Referer": url, | ||
| } | ||
|
|
| @@ -0,0 +1,25 @@ | |||
| ALTER TABLE feed ADD CONSTRAINT feed_stable_id_unique UNIQUE (stable_id); | |||
…tegrate-feeds-download
davidgamez
approved these changes
Sep 25, 2025
davidgamez
left a comment
davidgamez
left a comment
Member
There was a problem hiding this comment.
This is a minor feature that will open the door to a lot of fixed per-feed levels. Great work!
davidgamez
deleted the
1325-add-global-and-per-feed-configurationintegrate-feeds-download
branch
September 25, 2025 20:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #1325
This PR fixes the STM bug #1341, adding a header per feed allow us to download the STM zip file and unzip it accordingly.
Next steps: fill up ConfigValueFeed table manually.
Expected behavior:
https://www.stm.info/sites/default/files/gtfs/gtfs_stm.zip returns an html page and blocks scripts.
adding a header in the ConfigValueFeed table solves the problem.
Testing tips:
Provide tips, procedures and sample files on how to test the feature.
Testers are invited to follow the tips AND to try anything they deem relevant outside the bounds of the testing tips.
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything