Skip to content

fix: pmtiles error when missing latitude and longitude are missing on stops.txt#1364

Merged
davidgamez merged 7 commits intomainfrom
fix/pmtiles_missing_lat_long
Sep 19, 2025
Merged

fix: pmtiles error when missing latitude and longitude are missing on stops.txt#1364
davidgamez merged 7 commits intomainfrom
fix/pmtiles_missing_lat_long

Conversation

@davidgamez
Copy link
Copy Markdown
Member

@davidgamez davidgamez commented Sep 18, 2025

Summary:

Closes #1357
This PR adds protective code to stop latitude and longitude conversion, avoiding runtime errors.

Expected behavior:

Don't raise an error when missing or malformed stop latitude and longitude

Testing tips:
Tested in dev with mdb-437

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@davidgamez davidgamez marked this pull request as ready for review September 18, 2025 19:34
@davidgamez davidgamez changed the title Fix/pmtiles missing lat long fix: pmtiles error when missing latitude and longitude are missing on stops.txt Sep 18, 2025
@davidgamez davidgamez requested a review from cka-y September 18, 2025 19:36
Copy link
Copy Markdown
Contributor

@cka-y cka-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidgamez davidgamez merged commit 68e505f into main Sep 19, 2025
8 of 9 checks passed
@davidgamez davidgamez deleted the fix/pmtiles_missing_lat_long branch September 19, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pmtiles builder fails when stop latitude and longitude is missing

2 participants