fix: latest dataset filter and move db models to shared folder under shared folder#1410
Merged
Conversation
davidgamez
commented
Oct 22, 2025
|
|
||
| if latest: | ||
| query = query.join(Gtfsdataset.feed).filter(Gtfsdataset.id == FeedOrm.latest_dataset_id) | ||
| query = query.join(Gtfsfeed, Gtfsfeed.latest_dataset_id == Gtfsdataset.id) |
Member
Author
There was a problem hiding this comment.
Here is the latest dataset filter fix
jcpitre
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR moves the database models to the shared folder to be able to share these transformations with the Python functions. This PR also fixes a failing latest filtering in the datasets endpoint.
Expected behavior:
gtfs_feeds/<stable_id>/datasets, the API should behave the same as before, with no changes to the previous behaviour .gtfs_feeds/<stable_id>/datasetsendpoint a valid response in returned.Testing tips:
Latest dataset fix:
feed_stable_idwith a local ID.Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything