Feat: on validation report, set service date range + backfill error handling#930
Merged
davidgamez merged 7 commits intomainfrom Mar 3, 2025
Merged
Feat: on validation report, set service date range + backfill error handling#930davidgamez merged 7 commits intomainfrom
davidgamez merged 7 commits intomainfrom
Conversation
Alessandro100
force-pushed
the
feat/882-set-service-date-range
branch
from
930615b to
cb7e274
Compare
cka-y
approved these changes
Mar 3, 2025
Member
There was a problem hiding this comment.
[question]: I'm confused about the renaming of the files, is this not affecting the deployment of the function? I would expect a change in the terraform code after files are moved from one folder to another.
Contributor
There was a problem hiding this comment.
I suggested renaming the folder as it was confusing to map the function in GCP to the source code folder. But you're right lines 37-38 of the python functions terraform need to be updated
davidgamez
requested changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #882 and #881
Summary:
When the validation report is generated, add the service date range to the associated dataset. Also renamed the python function folder to better match the name of the function.
Added a error handling mechanism to the backfill function if getting the blog fails
Expected behavior:
When the validation report is processed, the associated dataset should have the service date range
If the blog exists, and it fails to get, it should default on the original url when backfilling the service date range
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything