pr updates

Author: Alessandro100

.github/workflows/README.md

@@ -1,9 +1,9 @@
 ## Vercel Deployments
 
-### Feature PR to main [vercel-preview-pr.yml](./vercel-preview-pr.yml)
-- Runs checks: lint, test, e2e:test
-- Creates a preview URL to test feature using the DEV environment
-- Generate Lighthouse report based on preview URL
+### Feature PR to main [preview-pr.yml](./preview-pr.yml)
+- Runs checks: lint, test (for all), e2e:test (for vercel access prs)
+- Creates a preview URL to test feature using the DEV environment (for vercel access prs)
+- Generate Lighthouse report based on preview URL (for vercel access prs)
 
 ### When feature is merged to main 
 - Vercel automatically deploys any new changes done in main to the staging environment

.github/workflows/vercel-preview-pr.yml .github/workflows/preview-pr.yml.github/workflows/vercel-preview-pr.yml renamed to .github/workflows/preview-pr.yml

@@ -1,19 +1,44 @@
-name: Vercel Preview (PR)
+name: Preview (PR)
 
 on:
   pull_request:
     branches: [main]
-    types: [opened, synchronize, reopened]
 
 concurrency:
   group: vercel-preview-${{ github.event.pull_request.number }}
   cancel-in-progress: true
 
+env:
+  NODE_VERSION: '24.12.0'
+
 jobs:
-  deploy_preview:
-    # ✅ Only run for same-repo PRs (not forks)
-    if: ${{ github.event.pull_request.head.repo.full_name == github.repository }}
+  # ✅ Runs for all PRs (including forks)
+  lint_and_test:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout PR
+        uses: actions/checkout@v4
+
+      - name: Setup Node
+        uses: actions/setup-node@v4
+        with:
+          node-version: ${{ env.NODE_VERSION }}
+          cache: yarn
+
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile --prefer-offline
+
+      - name: Lint
+        run: yarn lint
+
+      - name: Unit tests
+        run: yarn test:ci
 
+  # ✅ Only runs for same-repo PRs (not forks) - requires secrets
+  e2e_and_preview:
+    if: ${{ github.event.pull_request.head.repo.full_name == github.repository }}
+    needs: lint_and_test
     runs-on: ubuntu-latest
     permissions:
       contents: read
@@ -37,7 +62,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v4
         with:
-          node-version: 24.12.0
+          node-version: ${{ env.NODE_VERSION }}
           cache: yarn
 
       - name: Install dependencies
@@ -51,12 +76,6 @@ jobs:
           restore-keys: |
             cypress-${{ runner.os }}-binary-
 
-      - name: Lint
-        run: yarn lint
-
-      - name: Unit tests
-        run: yarn test:ci
-
       - name: Install Vercel CLI
         run: npm i -g vercel@latest
 

.github/workflows/vercel-prod-on-release.yml

@@ -5,6 +5,9 @@ on:
   release:
     types: [published]
 
+env:
+  NODE_VERSION: '24.12.0'
+
 jobs:
   deploy:
     runs-on: ubuntu-latest
@@ -30,7 +33,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@v4
         with:
-          node-version: 24.12.0
+          node-version: ${{ env.NODE_VERSION }}
           cache: 'yarn'
 
       - name: Install Vercel CLI
@@ -45,9 +48,9 @@ jobs:
       - uses: actions/cache@v4
         with:
             path: .next/cache
-            key: ${{ runner.os }}-nextcache-node24.12.0-${{ hashFiles('yarn.lock') }}-${{ github.sha }}
+            key: ${{ runner.os }}-nextcache-node${{ env.NODE_VERSION }}-${{ hashFiles('yarn.lock') }}-${{ github.sha }}
             restore-keys: |
-                ${{ runner.os }}-nextcache-node24.12.0-${{ hashFiles('yarn.lock') }}-
+                ${{ runner.os }}-nextcache-node${{ env.NODE_VERSION }}-${{ hashFiles('yarn.lock') }}-
 
 
       - name: Install deps