Merge pull request #87 from MobilityData/feat/81-dataset-unzipped-sizes

feat: display dataset size in table

Author: Alessandro100

messages/en.json

@@ -47,6 +47,7 @@
       "errors": "errors",
       "noErrors": "No errors",
       "noWarnings": "No warnings",
+      "noInfoNotices": "No info notices",
       "warnings": "warnings",
       "infoNotices": "info notices"
     },
@@ -266,6 +267,8 @@
     "datasetHistoryColumns": {
       "downloadedAt": "Downloaded At",
       "serviceDateRange": "Service Date Range",
+      "sizeZipped": "Size Zipped (MB)",
+      "sizeUnzipped": "Size Unzipped (MB)",
       "validationReport": "Validation Report",
       "actions": "Actions"
     },

messages/fr.json

@@ -47,6 +47,7 @@
       "errors": "errors",
       "noErrors": "No errors",
       "noWarnings": "No warnings",
+      "noInfoNotices": "Aucune notice d'information",
       "warnings": "warnings",
       "infoNotices": "info notices"
     },
@@ -266,6 +267,8 @@
     "datasetHistoryColumns": {
       "downloadedAt": "Téléchargé le",
       "serviceDateRange": "Plage de dates de service",
+      "sizeZipped": "Taille compressée (Mo)",
+      "sizeUnzipped": "Taille décompressée (Mo)",
       "validationReport": "Rapport de validation",
       "actions": "Actions"
     },

src/app/screens/Feed/components/DataQualitySummary.tsx

@@ -42,9 +42,9 @@ export default async function DataQualitySummary({
             <>
               <Chip
                 data-testid='error-count'
-                clickable
+                clickable={Boolean(latestDataset?.validation_report?.url_html)}
                 component='a'
-                href={latestDataset?.validation_report?.url_html}
+                href={latestDataset?.validation_report?.url_html ?? undefined}
                 target='_blank'
                 rel='noopener noreferrer nofollow'
                 icon={
@@ -77,9 +77,9 @@ export default async function DataQualitySummary({
 
               <Chip
                 data-testid='warning-count'
-                clickable
+                clickable={Boolean(latestDataset?.validation_report?.url_html)}
                 component='a'
-                href={latestDataset?.validation_report?.url_html}
+                href={latestDataset?.validation_report?.url_html ?? undefined}
                 target='_blank'
                 rel='noopener noreferrer nofollow'
                 icon={
@@ -112,16 +112,29 @@ export default async function DataQualitySummary({
 
               <Chip
                 data-testid='info-count'
-                icon={<InfoOutlinedIcon />}
-                clickable
+                icon={
+                  (latestDataset?.validation_report?.unique_info_count ?? 0) >
+                  0 ? (
+                    <InfoOutlinedIcon />
+                  ) : (
+                    <CheckCircle />
+                  )
+                }
+                clickable={Boolean(latestDataset?.validation_report?.url_html)}
                 component='a'
-                href={latestDataset?.validation_report?.url_html}
+                href={latestDataset?.validation_report?.url_html ?? undefined}
                 target='_blank'
                 rel='noopener noreferrer nofollow'
-                label={`${
-                  latestDataset?.validation_report?.unique_info_count ?? '0'
-                } ${tCommon('feedback.infoNotices')}`}
-                color='primary'
+                label={
+                  (latestDataset?.validation_report?.unique_info_count ?? 0) > 0
+                    ? `${latestDataset?.validation_report?.unique_info_count} ${tCommon('feedback.infoNotices')}`
+                    : tCommon('feedback.noInfoNotices')
+                }
+                color={
+                  (latestDataset?.validation_report?.unique_info_count ?? 0) > 0
+                    ? 'primary'
+                    : 'success'
+                }
                 variant='outlined'
               />
             </>