Skip to content

Commit d1afc0a

Browse files
committed
validation report null guard
1 parent c419c61 commit d1afc0a

File tree

2 files changed

+24
-12
lines changed

2 files changed

+24
-12
lines changed

src/app/screens/Feed/components/DataQualitySummary.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ export default async function DataQualitySummary({
4242
<>
4343
<Chip
4444
data-testid='error-count'
45-
clickable
45+
clickable={Boolean(latestDataset?.validation_report?.url_html)}
4646
component='a'
47-
href={latestDataset?.validation_report?.url_html}
47+
href={latestDataset?.validation_report?.url_html ?? undefined}
4848
target='_blank'
4949
rel='noopener noreferrer nofollow'
5050
icon={
@@ -77,9 +77,9 @@ export default async function DataQualitySummary({
7777

7878
<Chip
7979
data-testid='warning-count'
80-
clickable
80+
clickable={Boolean(latestDataset?.validation_report?.url_html)}
8181
component='a'
82-
href={latestDataset?.validation_report?.url_html}
82+
href={latestDataset?.validation_report?.url_html ?? undefined}
8383
target='_blank'
8484
rel='noopener noreferrer nofollow'
8585
icon={
@@ -120,9 +120,9 @@ export default async function DataQualitySummary({
120120
<CheckCircle />
121121
)
122122
}
123-
clickable
123+
clickable={Boolean(latestDataset?.validation_report?.url_html)}
124124
component='a'
125-
href={latestDataset?.validation_report?.url_html}
125+
href={latestDataset?.validation_report?.url_html ?? undefined}
126126
target='_blank'
127127
rel='noopener noreferrer nofollow'
128128
label={

src/app/screens/Feed/components/PreviousDatasets.tsx

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -266,8 +266,12 @@ export default function PreviousDatasets({
266266
>
267267
<Chip
268268
component='a'
269-
clickable
270-
href={`${dataset?.validation_report?.url_html}`}
269+
clickable={Boolean(
270+
dataset?.validation_report?.url_html,
271+
)}
272+
href={
273+
dataset?.validation_report?.url_html ?? undefined
274+
}
271275
target='_blank'
272276
rel='noreferrer nofollow'
273277
sx={{
@@ -336,8 +340,12 @@ export default function PreviousDatasets({
336340
},
337341
}}
338342
component='a'
339-
clickable
340-
href={`${dataset?.validation_report?.url_html}`}
343+
clickable={Boolean(
344+
dataset?.validation_report?.url_html,
345+
)}
346+
href={
347+
dataset?.validation_report?.url_html ?? undefined
348+
}
341349
target='_blank'
342350
rel='noreferrer nofollow'
343351
icon={
@@ -398,8 +406,12 @@ export default function PreviousDatasets({
398406
},
399407
}}
400408
component='a'
401-
clickable
402-
href={`${dataset?.validation_report?.url_html}`}
409+
clickable={Boolean(
410+
dataset?.validation_report?.url_html,
411+
)}
412+
href={
413+
dataset?.validation_report?.url_html ?? undefined
414+
}
403415
target='_blank'
404416
rel='noreferrer nofollow'
405417
icon={

0 commit comments

Comments
 (0)