Fix Firefox inline button spacing on FAQ and About pages#98
Fix Firefox inline button spacing on FAQ and About pages#98Alessandro100 merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Agent-Logs-Url: https://github.com/MobilityData/mobilitydatabase-web/sessions/08c20f63-9eb3-4bd5-899e-6fba366f1dd9 Co-authored-by: Alessandro100 <18631060+Alessandro100@users.noreply.github.com>
|
|
Alessandro100
left a comment
There was a problem hiding this comment.
tested on firefox and works well
|
*Lighthouse ran on https://mobilitydatabase-ax42lsot4-mobility-data.vercel.app/ * (Desktop)
*Lighthouse ran on https://mobilitydatabase-ax42lsot4-mobility-data.vercel.app/feeds * (Desktop)
*Lighthouse ran on https://mobilitydatabase-ax42lsot4-mobility-data.vercel.app/feeds/gtfs/mdb-2126 * (Desktop)
*Lighthouse ran on https://mobilitydatabase-ax42lsot4-mobility-data.vercel.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
*Lighthouse ran on https://mobilitydatabase-ax42lsot4-mobility-data.vercel.app/feeds/gbfs/gbfs-flamingo_porirua * (Desktop)
|
In Firefox, inline text buttons on the FAQ, About, and Feed Submission pages had no visible space between surrounding text and the button label — e.g.
"However, toadd a feed"instead of"However, to add a feed".Root cause
The spacer used before
line-start inlinebuttons was— the HTML entity for U+0014 (ASCII DC4, a non-printing control character). Chromium happens to render it as whitespace; Firefox does not.Fix
Replace all 10 instances of
with{' '}(a proper JSX space) across three files:src/app/screens/FAQ.tsx— 7 occurrencessrc/app/[locale]/about/components/AboutPage.tsx— 2 occurrencessrc/app/screens/FeedSubmission/index.tsx— 1 occurrenceThe
line-startclass (which zeroes left padding to avoid double-spacing) continues to work correctly — the space is now provided by a real U+0020 character rather than a control character.