Skip to content

Fix Firefox inline button spacing on FAQ and About pages#98

Merged
Alessandro100 merged 2 commits intomainfrom
copilot/fix-button-spacing-firefox
Apr 7, 2026
Merged

Fix Firefox inline button spacing on FAQ and About pages#98
Alessandro100 merged 2 commits intomainfrom
copilot/fix-button-spacing-firefox

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 7, 2026

In Firefox, inline text buttons on the FAQ, About, and Feed Submission pages had no visible space between surrounding text and the button label — e.g. "However, toadd a feed" instead of "However, to add a feed".

Root cause

The spacer used before line-start inline buttons was  — the HTML entity for U+0014 (ASCII DC4, a non-printing control character). Chromium happens to render it as whitespace; Firefox does not.

Fix

Replace all 10 instances of  with {' '} (a proper JSX space) across three files:

  • src/app/screens/FAQ.tsx — 7 occurrences
  • src/app/[locale]/about/components/AboutPage.tsx — 2 occurrences
  • src/app/screens/FeedSubmission/index.tsx — 1 occurrence
- However, to
+ However, to{' '}
  <Button variant='text' className='line-start inline' ...>

The line-start class (which zeroes left padding to avoid double-spacing) continues to work correctly — the space is now provided by a real U+0020 character rather than a control character.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mobilitydatabase-web Ready Ready Preview, Comment Apr 7, 2026 2:23pm

Request Review

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI changed the title [WIP] Fix button text spacing issue in Firefox Fix Firefox inline button spacing on FAQ and About pages Apr 7, 2026
Copilot AI requested a review from Alessandro100 April 7, 2026 14:25
Copy link
Copy Markdown
Contributor

@Alessandro100 Alessandro100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on firefox and works well

@Alessandro100 Alessandro100 marked this pull request as ready for review April 7, 2026 15:41
Copy link
Copy Markdown
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

*Lighthouse ran on https://mobilitydatabase-ax42lsot4-mobility-data.vercel.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟢 96 🟢 94 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-ax42lsot4-mobility-data.vercel.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 87 🟠 87 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-ax42lsot4-mobility-data.vercel.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🔴 45 🟢 94 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-ax42lsot4-mobility-data.vercel.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 82 🟠 84 🟢 96 🟢 100

*Lighthouse ran on https://mobilitydatabase-ax42lsot4-mobility-data.vercel.app/feeds/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance Accessibility Best Practices SEO
🟠 83 🟢 94 🟢 96 🟢 100

@Alessandro100 Alessandro100 merged commit 79e8543 into main Apr 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Firefox] Text that is close to a button is attached

4 participants