This repository was archived by the owner on May 30, 2021. It is now read-only.
Fix shared options between instances of DataTables#58
Open
Co-qn wants to merge 1 commit into
Open
Conversation
|
@Co-qn Have you checked whether this is the only thing that is apparently leaking into the global namespace? |
Owner
|
@johanneswilm - The ES2015+ module route was something I was considering. Maybe it's time to put it in to action as the library seems to be fairly popular. I'll look into refactoring after the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using multiple data tables in a HTML, it seems that options for each instances are shared.
I discover it is because of the
defaultConfigobject is broken changed when creating DataTable instances.Example
Expected
table1has set default perPage = 25.table2has set default perPage = 10(default).table1has 2 records.table2has no records.Actual(before fixed by this PR)
table1has set default perPage = 25.table2has set default perPage = 25.table1has 2 records.table2has 2 records.