Skip to content
This repository was archived by the owner on May 30, 2021. It is now read-only.

Fix: Columns rebuild row.cloneNode: TD's duplicated (TD²) #65

Open
sudwebdesign wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Columns rebuild row.cloneNode: TD's duplicated (TD²) #65

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0239a4
Fix: Columns rebuild row.cloneNode: TD's duplicated (TD²)
sudwebdesign Apr 30, 2018
f59faa7
same thing ?
sudwebdesign Apr 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/vanilla-dataTables.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,8 +476,8 @@

// Order the row cells
each(dt.data, function (row, i) {
c = row.cloneNode();
d = row.cloneNode();
c = row.cloneNode(false);
d = row.cloneNode(false);

c.dataIndex = d.dataIndex = i;

Expand Down Expand Up @@ -796,8 +796,8 @@

// Loop over the rows and reorder the cells
each(dt.data, function (row, i) {
a = row.cloneNode();
b = row.cloneNode();
a = row.cloneNode(false);
b = row.cloneNode(false);

a.dataIndex = b.dataIndex = i;

Expand All @@ -811,9 +811,9 @@
c.data = cell.data;
a.appendChild(c);

if (dt.hiddenColumns.indexOf(cell.cellIndex) < 0) {
d = cell.cloneNode(true);
d.data = cell.data;
if (dt.hiddenColumns.indexOf(c.cellIndex) < 0) {
d = c.cloneNode(true);
d.data = c.data;
b.appendChild(d);
}
});
Expand Down Expand Up @@ -846,7 +846,7 @@
* @return {HTMLElement}
*/
Rows.prototype.build = function (row) {
var td, tr = createElement("tr");
var tr = createElement("tr");

var headings = this.dt.headings;

Expand All @@ -857,7 +857,7 @@
}

each(headings, function (h, i) {
td = createElement("td");
var td = createElement("td");

// Fixes #29
if (!row[i] && !row[i].length) {
Expand Down