Skip to content

Commit 2af7ce1

Browse files
authored
Refactor game_cassettebeasts.py for clarity
Refactor imports and variable initializations, and improve readability by renaming loop variables.
1 parent dd51459 commit 2af7ce1

1 file changed

Lines changed: 13 additions & 14 deletions

File tree

games/game_cassettebeasts.py

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,23 @@
1+
from collections.abc import Mapping, Sequence
2+
from datetime import datetime
3+
from functools import cached_property
4+
from io import BytesIO
5+
from typing import Any, Optional
6+
from pathlib import Path
17
import json
28
import math
39
import os
410
import shutil
511
import struct
612
import zlib
7-
import mobase
813

9-
from collections.abc import Mapping, Sequence
10-
from datetime import datetime
11-
from functools import cached_property
12-
from io import BytesIO
13-
from typing import Any, Optional
14-
from pathlib import Path
14+
import mobase
15+
from PyQt6.QtCore import QDateTime, QDir, QFile, QFileInfo
1516

1617
from ..basic_features import BasicLocalSavegames
1718
from ..basic_features.basic_save_game_info import (BasicGameSaveGame,BasicGameSaveGameInfo)
1819
from ..basic_game import BasicGame
1920

20-
from PyQt6.QtCore import QDateTime, QDir, QFile, QFileInfo
21-
2221

2322
def json_get_me(value: Any, path: Sequence[str | int], /, default: Any) -> Any:
2423
for part in path:
@@ -66,8 +65,8 @@ def fix(self, filetree: mobase.IFileTree) -> mobase.IFileTree:
6665

6766
class CassetteBlock:
6867
def __init__(self):
69-
compressed_size = None
70-
data = None
68+
compressed_size: str = "(unknown)"
69+
data: str = "(unknown)"
7170

7271
class CassetteBeastsSaveGame(BasicGameSaveGame):
7372
def __init__(self, filepath: Path):
@@ -85,23 +84,23 @@ def __init__(self, filepath: Path):
8584
info = bytearray()
8685
data = bytes()
8786
with open(filepath, 'rb') as infile:
88-
magic_string = infile.read(4)
87+
infile.read(4)
8988

9089
compression_mode, blocksize, raw_size = struct.unpack("III", infile.read(12))
9190

9291
num_blocks = math.ceil(raw_size / blocksize)
9392

9493
blocks = []
9594

96-
for bnum in range(num_blocks):
95+
for _bnum in range(num_blocks):
9796
block = CassetteBlock()
9897
block.compressed_size = struct.unpack("I", infile.read(4))[0]
9998
blocks.append(block)
10099

101100
for block in blocks:
102101
block.data = infile.read(block.compressed_size)
103102

104-
magic_string = infile.read(4)
103+
infile.read(4)
105104
infile.close()
106105
for block in blocks:
107106
data = zlib.decompress(block.data, wbits=40, bufsize=blocksize)

0 commit comments

Comments
 (0)