Skip to content

Change IOrganizer::profile return type to a shared_ptr #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Holt59 merged 3 commits into from
Jan 11, 2026
Merged

Change IOrganizer::profile return type to a shared_ptr #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ff5bfd
Change IOrganizer::profile return type to a shared_ptr
JonathanFeenstra Jan 11, 2026
85e207c
Allow non-cache build in CI when Azure variables are not available.
JonathanFeenstra Jan 11, 2026
fddaa3e
Undo formatting
JonathanFeenstra Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
types: [opened, synchronize, reopened]

env:
VCPKG_BINARY_SOURCES: clear;x-azblob,${{ vars.AZ_BLOB_VCPKG_URL }},${{ secrets.AZ_BLOB_SAS }},readwrite
VCPKG_BINARY_SOURCES: ${{ vars.AZ_BLOB_VCPKG_URL != '' && format('clear;x-azblob,{0},{1},readwrite', vars.AZ_BLOB_VCPKG_URL, secrets.AZ_BLOB_SAS) || '' }}

jobs:
build:
Expand Down
2 changes: 1 addition & 1 deletion src/OMODFrameworkWrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ OMODFrameworkWrapper::EInstallResult OMODFrameworkWrapper::install(MOBase::Guess
// force-enabled by engine
auto bsas = dataArchives->vanillaArchives();
// explicitly enabled in INI. For Oblivion, excludes the vanilla BSAs by default.
bsas.append(dataArchives->archives(mMoInfo->profile()));
bsas.append(dataArchives->archives(mMoInfo->profile().get()));
for (const auto& bsa : bsas)
{
QString path = mMoInfo->resolvePath(bsa);
Expand Down