[Minor] adding diagnostic class to sum up code behaviour upon failing, first rework of the error windowbox

Author: remyCases

Controls/ModInfos.xaml.cs

@@ -6,6 +6,7 @@
 using System.Threading.Tasks;
 using System.Windows;
 using System.Windows.Controls;
+using ModShardLauncher.Core.Errors;
 using ModShardLauncher.Mods;
 using Serilog;
 
@@ -36,7 +37,9 @@ private async void Save_Click(object sender, EventArgs e)
                 return;
             }
 
-            if (ModLoader.PatchFile())
+            MSLDiagnostic? diag = ModLoader.PatchFile();
+
+            if (diag is null)
             {
                 Main.Instance.LogModListStatus();
                 Log.Information("Successfully patch vanilla");
@@ -56,7 +59,9 @@ private async void Save_Click(object sender, EventArgs e)
             {
                 Main.Instance.LogModListStatus();
                 Log.Information("Failed patching vanilla");
-                MessageBox.Show("Patching failed, more information can be found in the logs.", Application.Current.FindResource("SaveDataWarning").ToString());
+                string messageBoxText = "Do you want to save changes?";
+                string caption = diag.Title();
+                MessageBox.Show(messageBoxText, caption);
             }
 
             // reload the data

Core/Errors/MSLDiagnostic.cs

@@ -0,0 +1,45 @@
+using System;
+using Serilog;
+
+namespace ModShardLauncher.Core.Errors
+{
+    public class MSLDiagnostic
+    {
+        public string ModName;
+        public string? FileName;
+        public string? PatchingMethod;
+        public Exception exception;
+        public MSLDiagnostic(Exception ex, ModFile modFile)
+        {
+            if (ex.Data.Contains("fileName"))
+            {
+                object? fileName = ex.Data["fileName"];
+                FileName = $"{fileName}";
+            }
+            if (ex.Data.Contains("patchingWay"))
+            {
+                object? patchingWay = ex.Data["patchingWay"];
+                PatchingMethod = $"{patchingWay}";
+            }
+            ModName = modFile.Name;
+            exception = ex;
+        }
+        public void ToLog()
+        {
+            string extraInformation = " for {{{0}}}";
+            if (FileName is not null)
+            {
+                extraInformation += " in file {{{1}}}";
+            }
+            if (PatchingMethod is not null)
+            {
+                extraInformation += " while patching by {{{2}}}";
+            }
+            Log.Error(exception, "Something went wrong" + extraInformation, ModName, FileName, PatchingMethod);
+        }
+        public string Title()
+        {
+            return $"{ModName} failed";
+        }
+    }
+}

Main.xaml.cs

@@ -156,6 +156,10 @@ public static void LogModStatus(ModFile modFile)
             }
             Log.Warning("Patching {{{2}}} for {{{0}}} {{{1}}}", modFile.Name, modFile.Version, statusMessage);
         }
+        public ModFile GetFailingMod()
+        {
+            return ModPage.Mods.Where(x => x.Enabled).First(x => x.PatchStatus == PatchStatus.Patching); ;
+        }
         private void MyToggleButton_Checked(object sender, EventArgs e)
         {
             foreach (var i in stackPanel.Children)

ModLoader.cs

@@ -13,6 +13,7 @@
 using UndertaleModLib.Models;
 using ModShardLauncher.Controls;
 using Serilog;
+using ModShardLauncher.Core.Errors;
 
 namespace ModShardLauncher
 {
@@ -183,7 +184,7 @@ public static void PatchMods()
             Msl.ChainDisclaimerRooms(Disclaimers);
             Msl.CreateMenu(Menus);
         }
-        public static bool PatchFile()
+        public static MSLDiagnostic? PatchFile()
         {
             try
             {
@@ -192,26 +193,13 @@ public static bool PatchFile()
                 PatchMods();
                 // add the new loot related functions if there is any
                 LootUtils.InjectLootScripts();
-                return true;
+                return null;
             }
             catch (Exception ex)
             {
-                string extraInformation = "";
-                object? fileName = null;
-                object? patchingWay = null;
-                if (ex.Data.Contains("fileName"))
-                {
-                    fileName = ex.Data["fileName"];
-                    extraInformation += " in file {{{0}}}";
-                }
-                if (ex.Data.Contains("patchingWay"))
-                {
-                    patchingWay = ex.Data["patchingWay"];
-                    extraInformation += " while patching by {{{1}}}";
-                }
-
-                Log.Error(ex, "Something went wrong" + extraInformation, fileName, patchingWay);
-                return false;
+                MSLDiagnostic diag = new(ex, Main.Instance.GetFailingMod());
+                diag.ToLog();
+                return diag;
             }
         }
     }

ModShardLauncher.csproj

@@ -21,7 +21,7 @@
     <Compile Include="Mods/*.cs" />
     <Compile Include="Controls/*.cs" />
     <Compile Include="ModUtils/*.cs" />
-    <Compile Include="Core/TopologicalOrdering/*.cs" />
+    <Compile Include="Core/**/*.cs" />
   </ItemGroup>
 
   <ItemGroup>