Skip to content

Commit 8bd1204

Browse files
authored
🐛 fix add tag error (#408)
1 parent 4b9ba3a commit 8bd1204

File tree

3 files changed

+34
-5
lines changed

3 files changed

+34
-5
lines changed

backend/services/data-management-service/src/main/java/com/datamate/datamanagement/application/TagApplicationService.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package com.datamate.datamanagement.application;
22

3+
import com.datamate.common.infrastructure.exception.BusinessException;
34
import com.datamate.datamanagement.domain.model.dataset.Tag;
5+
import com.datamate.datamanagement.infrastructure.exception.DataManagementErrorCode;
46
import com.datamate.datamanagement.infrastructure.persistence.mapper.TagMapper;
57
import org.springframework.beans.factory.annotation.Autowired;
68
import org.springframework.stereotype.Service;
@@ -30,7 +32,7 @@ public TagApplicationService(TagMapper tagMapper) {
3032
public Tag createTag(String name, String color, String description) {
3133
// 检查名称是否已存在
3234
if (tagMapper.findByName(name) != null) {
33-
throw new IllegalArgumentException("Tag with name '" + name + "' already exists");
35+
throw BusinessException.of(DataManagementErrorCode.TAG_NAME_DUPLICATE);
3436
}
3537

3638
Tag tag = new Tag(name, description, null, color);

frontend/public/config/error-code.json

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,29 @@
1616
"operator.0004": "不支持的文件类型,当前仅支持tar和zip",
1717
"operator.0005": "解析算子包失败",
1818
"operator.0006": "缺少必要的字段",
19+
"data_management.0001": "数据集不存在",
20+
"data_management.0002": "数据集已存在",
21+
"data_management.0003": "数据集状态错误",
22+
"data_management.0004": "数据集标签不存在",
23+
"data_management.0005": "数据集标签已存在",
24+
"data_management.0006": "数据集文件已存在",
25+
"data_management.0007": "目录不存在",
26+
"data_management.0008": "数据集名称长度不能超过255个字符",
27+
"data_management.0009": "数据集类型不合法",
28+
"data_management.0010": "数据集状态不合法",
29+
"data_management.0011": "标签名称长度不能超过100个字符",
30+
"data_management.0012": "标签名称已存在",
31+
"data_management.0013": "标签颜色格式不正确,应为十六进制颜色代码",
32+
"data_management.0014": "保留天数必须为非负整数",
33+
"data_management.0015": "路径长度不能超过限制",
34+
"data_management.0016": "文件名包含非法字符",
35+
"data_management.0017": "路径前缀不能以点开头",
36+
"sys.0001": "未知错误",
37+
"sys.0002": "系统繁忙,请稍后重试",
38+
"sys.0003": "参数错误",
39+
"sys.0004": "资源未找到",
40+
"sys.0005": "权限不足",
41+
"sys.0006": "文件系统错误",
1942
"400": "请求参数错误",
2043
"401": "登录已过期,请重新登录",
2144
"403": "没有权限访问该资源",

frontend/src/components/business/TagManagement.tsx

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,8 @@ const TagManager: React.FC = ({
119119
const { data } = await onFetch?.();
120120
setTags(data || []);
121121
} catch (e) {
122-
message.error(t("tagManagement.messages.fetchFailed"));
122+
// 错误已由全局拦截器处理,无需重复提示
123+
console.error("Failed to fetch tags:", e);
123124
}
124125
};
125126

@@ -133,7 +134,8 @@ const TagManager: React.FC = ({
133134
setNewTag("");
134135
message.success(t("tagManagement.messages.addSuccess"));
135136
} catch (error) {
136-
message.error(t("tagManagement.messages.addFailed"));
137+
// 错误已由全局拦截器处理,无需重复提示
138+
console.error("Failed to add tag:", error);
137139
}
138140
};
139141

@@ -144,7 +146,8 @@ const TagManager: React.FC = ({
144146
fetchTags();
145147
message.success(t("tagManagement.messages.deleteSuccess"));
146148
} catch (error) {
147-
message.error(t("tagManagement.messages.deleteFailed"));
149+
// 错误已由全局拦截器处理,无需重复提示
150+
console.error("Failed to delete tag:", error);
148151
}
149152
};
150153

@@ -154,7 +157,8 @@ const TagManager: React.FC = ({
154157
fetchTags();
155158
message.success(t("tagManagement.messages.updateSuccess"));
156159
} catch (error) {
157-
message.error(t("tagManagement.messages.updateFailed"));
160+
// 错误已由全局拦截器处理,无需重复提示
161+
console.error("Failed to update tag:", error);
158162
}
159163
};
160164

0 commit comments

Comments
 (0)