Skip to content

Commit 28a746f

Browse files
committed
[app-builder] 修改检视意见,修改恢复应用接口名称,补充操作日志日志和国际化信息
1 parent 1dc5d94 commit 28a746f

10 files changed

Lines changed: 39 additions & 23 deletions

File tree

app-builder/jane/plugins/aipp-plugin/src/main/java/modelengine/fit/jober/aipp/controller/AppBuilderAppController.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -430,16 +430,16 @@ public Rsp<AppBuilderAppDto> importApp(HttpClassicServerRequest httpRequest,
430430
*
431431
* @param httpRequest 表示 http 请求的 {@link HttpClassicServerRequest}。
432432
* @param tenantId 表示租户 id 的 {@link String}。
433-
* @param appId 表示应用 id 的 {@link String}。
434-
* @param resetAppId 表示指定历史版本 id 的 {@link String}。
433+
* @param appId 表示应用唯一标识的 {@link String}。
434+
* @param recoverAppId 表示指定历史版本唯一标识的 {@link String}。
435435
* @return 表示恢复后应用信息的 {@link AppBuilderAppDto}。
436436
*/
437-
@CarverSpan(value = "operation.appBuilderApp.resetApp")
438-
@PostMapping(path = "/reset/{app_id}")
439-
public Rsp<AppBuilderAppDto> resetApp(HttpClassicServerRequest httpRequest,
437+
@CarverSpan(value = "operation.appBuilderApp.recoverApp")
438+
@PostMapping(path = "/{app_id}/recover")
439+
public Rsp<AppBuilderAppDto> recoverApp(HttpClassicServerRequest httpRequest,
440440
@PathVariable("tenant_id") String tenantId, @PathVariable("app_id") String appId,
441-
@RequestBody String resetAppId) {
442-
return Rsp.ok(this.appService.resetApp(appId, resetAppId, contextOf(httpRequest, tenantId)));
441+
@RequestBody String recoverAppId) {
442+
return Rsp.ok(this.appService.recoverApp(appId, recoverAppId, contextOf(httpRequest, tenantId)));
443443
}
444444

445445
private AppQueryCondition buildAppQueryCondition(AppQueryCondition cond, String type) {

app-builder/jane/plugins/aipp-plugin/src/main/java/modelengine/fit/jober/aipp/service/AppBuilderAppService.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import modelengine.fit.jober.aipp.dto.template.TemplateAppCreateDto;
2424
import modelengine.fit.jober.aipp.dto.template.TemplateInfoDto;
2525
import modelengine.fit.jober.common.RangedResultSet;
26-
import modelengine.fit.http.server.HttpClassicServerRequest;
2726
import modelengine.fit.jane.common.entity.OperationContext;
2827
import modelengine.fitframework.annotation.Genericable;
2928

@@ -235,11 +234,11 @@ RangedResultSet<AppBuilderAppDto> recentPublished(AppQueryCondition cond, long o
235234
/**
236235
* 恢复应用到指定历史版本。
237236
*
238-
* @param appId 表示应用 id 的 {@link String}。
239-
* @param resetId 表示指定历史版本 id 的 {@link String}。
237+
* @param appId 表示应用唯一标识的 {@link String}。
238+
* @param resetId 表示指定历史版本唯一标识的 {@link String}。
240239
* @param context 表示接口操作上下文的 {@link OperationContext}。
241240
* @return 表示恢复应用完成后应用详情的 {@link AppBuilderAppDto}。
242241
*/
243-
@Genericable(id = "modelengine.fit.jober.aipp.service.app.reset")
244-
AppBuilderAppDto resetApp(String appId, String resetId, OperationContext context);
242+
@Genericable(id = "modelengine.fit.jober.aipp.service.app.recover")
243+
AppBuilderAppDto recoverApp(String appId, String resetId, OperationContext context);
245244
}

app-builder/jane/plugins/aipp-plugin/src/main/java/modelengine/fit/jober/aipp/service/impl/AppBuilderAppServiceImpl.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1310,10 +1310,9 @@ public List<CheckResult> checkAvailable(List<AppCheckDto> appCheckDtos, Operatio
13101310

13111311
@Override
13121312
@Transactional
1313-
public AppBuilderAppDto resetApp(String appId, String resetId, OperationContext context) {
1313+
public AppBuilderAppDto recoverApp(String appId, String resetId, OperationContext context) {
13141314
AppBuilderApp resetApp = this.appFactory.create(resetId);
13151315
AppBuilderApp currentApp = this.appFactory.create(appId);
1316-
// 更新graph和form property,需更新form property的app id以及graph的id、title
13171316
List<AppBuilderFormProperty> resetFormProperties = resetApp.getFormProperties();
13181317
List<AppBuilderFormProperty> currentFormProperties = currentApp.getFormProperties();
13191318
Map<String, AppBuilderFormProperty> currentPropMap = currentFormProperties.stream()

app-builder/jane/plugins/aipp-plugin/src/main/java/modelengine/fit/jober/aipp/util/MetaUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,10 @@ public static List<Meta> getAllPublishedMeta(MetaService metaService, String met
129129
}
130130

131131
/**
132-
* 分页查询指定应用的已发布meta列表,按更新时间倒序。
132+
* 分页查询指定应用的已发布元数据列表,按更新时间倒序。
133133
*
134134
* @param metaService 表示使用的 {@link MetaService}。
135-
* @param metaId 表示指定应用id的 {@link String}。
135+
* @param metaId 表示指定应用唯一标识的 {@link String}。
136136
* @param offset 表示偏移量的 {@code long}。
137137
* @param limit 表示单页最大数量的 {@code int}。
138138
* @param context 表示操作人上下文的 {@link OperationContext}。

app-builder/jane/plugins/aipp-plugin/src/test/java/modelengine/fit/jober/aipp/service/AppBuilderAppServiceImplTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -982,7 +982,7 @@ void testResetApp() {
982982

983983
when(this.appRepository.selectWithId(eq(currentAppId))).thenReturn(currentApp);
984984
when(this.appRepository.selectWithId(eq(resetAppId))).thenReturn(this.mockApp(resetAppId));
985-
AppBuilderAppDto dto = this.appBuilderAppService.resetApp(currentAppId, resetAppId, new OperationContext());
985+
AppBuilderAppDto dto = this.appBuilderAppService.recoverApp(currentAppId, resetAppId, new OperationContext());
986986

987987
assertThat(dto).extracting(dto1 -> dto1.getFlowGraph().getId(),
988988
dto1 -> dto1.getFlowGraph().getAppearance().get("id"),

app-engine/frontend/src/locale/en_US.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -958,5 +958,6 @@
958958
"resetSucceed": "Reset Succeed",
959959
"currentDraft": "Current Draft",
960960
"loading": "Loading",
961-
"noMore": "You've reached the end"
961+
"noMore": "You've reached the end",
962+
"latest": "latest"
962963
}

app-engine/frontend/src/locale/zh_CN.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -958,5 +958,6 @@
958958
"resetSucceed": "恢复应用成功",
959959
"currentDraft": "当前草稿",
960960
"loading": "加载中",
961-
"noMore": "已显示全部"
961+
"noMore": "已显示全部",
962+
"latest": "最新"
962963
}

app-engine/frontend/src/shared/http/aipp.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ export function templateCreateAipp(tenantId, params) {
222222
export function getApiDocument() {
223223
return get(`${AIPP_URL}/document`);
224224
}
225-
// reset应用到某个发布版本
225+
// 恢复应用到某个发布版本
226226
export function resetApp(tenantId, appId, params, headers) {
227-
return post(`${AIPP_URL}/${tenantId}/app/reset/${appId}`, params, headers);
227+
return post(`${AIPP_URL}/${tenantId}/app/${appId}/recover`, params, headers);
228228
}

carver/plugins/operation-log-locale/src/main/resources/i18n/messages_en.properties

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -572,4 +572,12 @@ operation.file.batch.upload.module=File service
572572
operation.file.batch.upload.resource=File
573573
operation.file.batch.upload.uri=/v1/api/{tenant_id}/files
574574
operation.file.batch.upload.succeed.detail=Files uploaded.
575-
operation.file.batch.upload.failed.detail=Failed to upload files. Cause: {{cause}}.
575+
operation.file.batch.upload.failed.detail=Failed to upload files. Cause: {{cause}}.
576+
577+
operation.appBuilderApp.recover=Recover an application
578+
operation.appBuilderApp.recover.level=MINOR
579+
operation.appBuilderApp.recover.module=Application service
580+
operation.appBuilderApp.recover.resource=Application
581+
operation.appBuilderApp.recover.uri=/v1/api/{{tenant_id}}/app/{{app_id}}/recover
582+
operation.appBuilderApp.recover.succeed.detail=Application recovered.
583+
operation.appBuilderApp.recover.failed.detail=Failed to recover the application. Cause: {{cause}}

carver/plugins/operation-log-locale/src/main/resources/i18n/messages_zh.properties

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -564,4 +564,12 @@ operation.file.batch.upload.module=文件服务
564564
operation.file.batch.upload.resource=文件
565565
operation.file.batch.upload.uri=/v1/api/{tenant_id}/files
566566
operation.file.batch.upload.succeed.detail=文件上传成功。
567-
operation.file.batch.upload.failed.detail=文件上传失败,原因:{{cause}}。
567+
operation.file.batch.upload.failed.detail=文件上传失败,原因:{{cause}}。
568+
569+
operation.appBuilderApp.recover=恢复应用到指定历史版本
570+
operation.appBuilderApp.recover.level=MINOR
571+
operation.appBuilderApp.recover.module=应用服务
572+
operation.appBuilderApp.recover.resource=应用
573+
operation.appBuilderApp.recover.uri=/v1/api/{{tenant_id}}/app/{{app_id}}/recover
574+
operation.appBuilderApp.recover.succeed.detail=恢复应用成功。
575+
operation.appBuilderApp.recover.failed.detail=恢复应用失败,原因:{{cause}}。

0 commit comments

Comments
 (0)