[app-builder] 优化部分性能，添加流程数据定时清理机制#21
Closed
FUNK6666 wants to merge 6 commits intoModelEngine-Group:mainfrom
Closed
[app-builder] 优化部分性能，添加流程数据定时清理机制#21FUNK6666 wants to merge 6 commits intoModelEngine-Group:mainfrom
FUNK6666 wants to merge 6 commits intoModelEngine-Group:mainfrom
Conversation
CodeCasterX
changed the title
CodeCasterX
added
in: builder
CodeCasterX
reviewed
Apr 9, 2025
| /** | ||
| * 用于缓存app_id和meta的关系 | ||
| */ | ||
| public static final Cache<String, Meta> AIPP_ID_LAST_META_CACHE = Caffeine.newBuilder() |
Member
There was a problem hiding this comment.
- 该缓存命名不明确，其中
LAST是什么意思？ - 该缓存是不是应该把访问权限收归到
private，然后仅通过方法来访问？而不是公开了之后支持任意访问 - 该缓存的注释需要调整，详细说清楚到底缓存了什么内容。
| * 用于获取flowdefinition的缓存 | ||
| * | ||
| * @param flowsService 操作flow的service | ||
| * @param flowsService 操作flow的service |
Member
There was a problem hiding this comment.
注释风格需要全团队统一，采用代码仓库提供的格式化文件，不需要参数注释对齐，同时注释需要采用统一风格。这里可以改成如下：
/**
* 通过缓存获取指定的已发布流程。
*
* @param flowsService 表示流程服务的 {@link FlowsService}。
* @param flowDefinitionId 表示流程定义的唯一标识的 {@link String}。
* @param context 表示操作上下文的 {@link OperationContext}。
* @return 表示缓存流程信息的 {@link FlowInfo}。
*/| private static Meta getLatestMetaByAppId(MetaService metaService, String appId, OperationContext context) { | ||
| List<Meta> metas = MetaUtils.getAllMetasByAppId(metaService, appId, context); | ||
| if (CollectionUtils.isEmpty(metas)) { | ||
| throw new AippException(AippErrCode.APP_CHAT_DEBUG_META_NOT_FOUND); |
Member
There was a problem hiding this comment.
这里抛出异常的时候无日志，也没有将必要的参数信息透出，会对定位问题造成困扰。
| if (isDebug) { | ||
| return getLatestMetaByAppId(metaService, appId, context); | ||
| } | ||
| // get一个aipp_id的缓存，然后根据aipp_id查询最新发布版的meta |
Member
There was a problem hiding this comment.
如果要进行行内注释，需要写清楚，尽量不要中英文混杂，同时，团队统一规范，最后加上全角句号
| private Context context; | ||
|
|
||
| /** | ||
| * 判断是否有@应用 |
| import java.util.concurrent.ThreadLocalRandom; | ||
|
|
||
| /** | ||
| * Uuid的Utils类。 |
Member
There was a problem hiding this comment.
注释调整，同时 @since 后面需要跟创建该文件的时间，格式为 yyyy-MM-dd
CodeCasterX
reviewed
Apr 9, 2025
| */ | ||
| @Scheduled(strategy = Scheduled.Strategy.CRON, value = "0 0 3 * * ?") | ||
| @Transactional | ||
| public void cleanContextSchedule() { |
Member
There was a problem hiding this comment.
该方法识别为重点方法，逻辑看样子存在数据库的访问删除操作，且每次操作都和当前操作时间有关，因为使用的是定时任务，当多实例并发时，就会产生并发数据库删除，当前还存在事务，是否在并发场景下该逻辑是有效的？请仔细分析，将分析结果写在注释上，方便后续维护。
| * 包括成功、失败、终止的流程数据 | ||
| * | ||
| * @author 杨祥宇 | ||
| * @since 2025/04/02 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1、添加流程数据定期清理机制
2、更改waterflow中条件表达式执行时uuid生成规则，提升性能
3、添加缓存，提升对话性能