Skip to content

[frontend] bugfix: Incorrect read-only state after opening app publish history#251

Merged
CodeCasterX merged 1 commit into
ModelEngine-Group:developfrom
reeeborn33:bugfix-graph-readonly-bugs
Jun 13, 2025
Merged

[frontend] bugfix: Incorrect read-only state after opening app publish history#251
CodeCasterX merged 1 commit into
ModelEngine-Group:developfrom
reeeborn33:bugfix-graph-readonly-bugs

Conversation

@reeeborn33
Copy link
Copy Markdown
Contributor

@reeeborn33 reeeborn33 commented Jun 12, 2025

🔗 相关问题 / Related Issue

Issue 链接 / Issue Link: #242

  • 我已经创建了相关 Issue 并进行了讨论 / I have created and discussed the related issue
  • 这是一个微小的修改(如错别字),不需要 Issue / This is a trivial change (like typo fix) that doesn't need an issue

📋 变更类型 / Type of Change

  • 🐛 Bug 修复 / Bug fix (non-breaking change which fixes an issue)
  • ✨ 新功能 / New feature (non-breaking change which adds functionality)
  • 💥 破坏性变更 / Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 文档更新 / Documentation update
  • 🔧 重构 / Refactoring (no functional changes)
  • ⚡ 性能优化 / Performance improvement
  • 🧹 代码清理 / Code cleanup

📝 变更目的 / Purpose of the Change

📋 主要变更 / Brief Changelog

  • 打开发布历史记录抽屉页时,设置elsaReadOnlyRef状态为true / When opening the publish history drawer, set the elsaReadOnlyRef state to true
  • 工作流编排页面点击左上角返回按钮时,判断是否为readonly状态,如果是不更新graph数据 / When clicking the back button in the workflow orchestration page, check if it is in read-only mode; if so, do not update the graph data

🧪 验证变更 / Verifying this Change

测试步骤 / Test Steps

  1. 进入应用开发,进入已发布的应用,打开发布历史记录,进入工作流编排,画布进入只读模式 /Enter App Development, open a published app, open the publish history, and enter the Workflow Orchestration page — the canvas enters read-only mode
  2. 进入应用开发,进入工作流编排,打开发布历史记录,点击返回到应用详情页,再次进入应用打开工作流编排,节点可以移动 / Enter App Development, go to the Workflow Orchestration page, open the publish history, click the back button to return to the App Details page, then re-enter the app and open the Workflow Orchestration page — the nodes can be moved
  3. 进入插件市场,进入已发布的工具流,打开发布历史记录,点击返回按钮,再次进入工具流,节点可以移动 / Enter the Plugin Marketplace, open a published toolflow, open the publish history, click the back button, then re-enter the toolflow — the nodes can be moved

测试覆盖 / Test Coverage

  • 我已经添加了单元测试 / I have added unit tests
  • 所有现有测试都通过 / All existing tests pass
  • 我已经进行了手动测试 / I have performed manual testing

📸 截图 / Screenshots

✅ 贡献者检查清单 / Contributor Checklist

请确保你的 Pull Request 符合以下要求 / Please ensure your Pull Request meets the following requirements:

基本要求 / Basic Requirements:

  • 确保有 GitHub Issue 对应这个变更(微小变更如错别字除外)/ Make sure there is a Github issue filed for the change (trivial changes like typos excluded)
  • 你的 Pull Request 只解决一个 Issue,没有包含其他不相关的变更 / Your PR addresses just this issue, without pulling in other changes - one PR resolves one issue
  • PR 中的每个 commit 都有有意义的主题行和描述 / Each commit in the PR has a meaningful subject line and body

代码质量 / Code Quality:

  • 我的代码遵循项目的代码规范 / My code follows the project's coding standards
  • 我已经进行了自我代码审查 / I have performed a self-review of my code
  • 我已经为复杂的代码添加了必要的注释 / I have commented my code, particularly in hard-to-understand areas

测试要求 / Testing Requirements:

  • 我已经编写了必要的单元测试来验证逻辑正确性 / I have written necessary unit-tests to verify the logic correction
  • 当存在跨模块依赖时,我尽量使用了 mock / I have used mocks when cross-module dependencies exist
  • 基础检查通过:mvn -B clean package -Dmaven.test.skip=truenpm install --force && npm run build:pro / Basic checks pass
  • 单元测试通过:mvn clean install / Unit tests pass

文档和兼容性 / Documentation and Compatibility:

  • 我已经更新了相应的文档 / I have made corresponding changes to the documentation
  • 如果有破坏性变更,我已经在 PR 描述中详细说明 / If there are breaking changes, I have documented them in detail
  • 我已经考虑了向后兼容性 / I have considered backward compatibility

📋 附加信息 / Additional Notes


审查者注意事项 / Reviewer Notes:

… in readonly mode; 2. sometimes the graph doesn't go into readonly mode.
@reeeborn33 reeeborn33 added this to the 1.1.1 milestone Jun 12, 2025
@reeeborn33 reeeborn33 requested review from a team, Msquittto and wjn1584 June 12, 2025 11:45
@reeeborn33 reeeborn33 self-assigned this Jun 12, 2025
@reeeborn33 reeeborn33 added type: bug A general bug in: frontend Issues in frontend labels Jun 12, 2025
@reeeborn33 reeeborn33 added this to Nova Jun 12, 2025
@CodeCasterX CodeCasterX linked an issue Jun 13, 2025 that may be closed by this pull request
4 tasks
@CodeCasterX
Copy link
Copy Markdown
Member

image

请将标题多余的内容精炼总结一下,使得标题完整,实在多的内容放到下面的描述中去

@reeeborn33 reeeborn33 changed the base branch from main to develop June 13, 2025 06:17
@CodeCasterX
Copy link
Copy Markdown
Member

请确保基础编译自检能够通过,然后勾选确认

@CodeCasterX CodeCasterX merged commit 0ffca2b into ModelEngine-Group:develop Jun 13, 2025
@github-project-automation github-project-automation Bot moved this to Done in Nova Jun 13, 2025
@reeeborn33 reeeborn33 removed this from RoadMap Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: frontend Issues in frontend type: bug A general bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

打开应用发布历史记录后,只读模式状态有误

4 participants