Skip to content

[tool] Support for blank properties in json schema#345

Merged
CodeCasterX merged 1 commit intoModelEngine-Group:1.2.xfrom
surpercodehang:enhancement-properties
Jul 23, 2025
Merged

[tool] Support for blank properties in json schema#345
CodeCasterX merged 1 commit intoModelEngine-Group:1.2.xfrom
surpercodehang:enhancement-properties

Conversation

@surpercodehang
Copy link
Copy Markdown
Contributor

@surpercodehang surpercodehang commented Jul 23, 2025

🔗 相关问题 / Related Issue

支持空白的值为 properties,对标参数类型为 object 的参数 / Supports blank values for properties, and corresponds to parameters whose parameter type is object

Issue 链接 / Issue Link: #

  • 我已经创建了相关 Issue 并进行了讨论 / I have created and discussed the related issue
  • 这是一个微小的修改(如错别字),不需要 Issue / This is a trivial change (like typo fix) that doesn't need an issue

📋 变更类型 / Type of Change

  • 🐛 Bug 修复 / Bug fix (non-breaking change which fixes an issue)
  • ✨ 新功能 / New feature (non-breaking change which adds functionality)
  • 💥 破坏性变更 / Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 文档更新 / Documentation update
  • 🔧 重构 / Refactoring (no functional changes)
  • ⚡ 性能优化 / Performance improvement
  • 📦 依赖升级 / Dependency upgrade (update dependencies to newer versions)
  • 🚀 功能增强 / Feature enhancement (improve existing functionality without breaking changes)
  • 🧹 代码清理 / Code cleanup

📝 变更目的 / Purpose of the Change

插件上传支持参数类型为 object 的参数,对接 mcp 后,上传插件的元数据更新,参数类型为 object 的元数据需要添加 "properties" : { } 字段,所以上传校验需要支持 properties 的 value 值为空的校验。/ Plugin upload supports parameters with parameter type of object. After connecting to MCP, the metadata of the upload plugin is updated. The metadata with parameter type of object needs to add the "properties": {} field, so the upload verification needs to support the verification that the value of properties is empty.

📋 主要变更 / Brief Changelog

  • 上传校验需要支持 properties 的 value 值为空的校验 / Upload verification needs to support verification of empty properties value
  • 更新单测 / Update single test

🧪 验证变更 / Verifying this Change

测试步骤 / Test Steps

  1. 单测通过 / Passed single test
  2. 部署环境,上传最新插件,上传成功 / Deployment environment, upload the latest plug-in, upload successfully

测试覆盖 / Test Coverage

  • 我已经添加了单元测试 / I have added unit tests
  • 所有现有测试都通过 / All existing tests pass
  • 我已经进行了手动测试 / I have performed manual testing

📸 截图 / Screenshots

✅ 贡献者检查清单 / Contributor Checklist

请确保你的 Pull Request 符合以下要求 / Please ensure your Pull Request meets the following requirements:

基本要求 / Basic Requirements:

  • 确保有 GitHub Issue 对应这个变更(微小变更如错别字除外)/ Make sure there is a Github issue filed for the change (trivial changes like typos excluded)
  • 你的 Pull Request 只解决一个 Issue,没有包含其他不相关的变更 / Your PR addresses just this issue, without pulling in other changes - one PR resolves one issue
  • PR 中的每个 commit 都有有意义的主题行和描述 / Each commit in the PR has a meaningful subject line and body

代码质量 / Code Quality:

  • 我的代码遵循项目的代码规范 / My code follows the project's coding standards
  • 我已经进行了自我代码审查 / I have performed a self-review of my code
  • 我已经为复杂的代码添加了必要的注释 / I have commented my code, particularly in hard-to-understand areas

测试要求 / Testing Requirements:

  • 我已经编写了必要的单元测试来验证逻辑正确性 / I have written necessary unit-tests to verify the logic correction
  • 当存在跨模块依赖时,我尽量使用了 mock / I have used mocks when cross-module dependencies exist
  • 基础检查通过:mvn -B clean package -Dmaven.test.skip=truenpm install --force && npm run build:pro / Basic checks pass
  • 单元测试通过:mvn clean install / Unit tests pass

文档和兼容性 / Documentation and Compatibility:

  • 我已经更新了相应的文档 / I have made corresponding changes to the documentation
  • 如果有破坏性变更,我已经在 PR 描述中详细说明 / If there are breaking changes, I have documented them in detail
  • 我已经考虑了向后兼容性 / I have considered backward compatibility

📋 附加信息 / Additional Notes


审查者注意事项 / Reviewer Notes:

@surpercodehang surpercodehang added this to the 1.2.1 milestone Jul 23, 2025
@surpercodehang surpercodehang self-assigned this Jul 23, 2025
@surpercodehang surpercodehang added the type: enhancement A general enhancement label Jul 23, 2025
@surpercodehang surpercodehang moved this to In review in Nova Jul 23, 2025
@surpercodehang surpercodehang force-pushed the enhancement-properties branch from 249f3b5 to ba10f38 Compare July 23, 2025 08:44
@surpercodehang surpercodehang changed the base branch from main to 1.2.x July 23, 2025 09:05
@CodeCasterX CodeCasterX added the in: builder Issues in app-builder modules label Jul 23, 2025
@CodeCasterX CodeCasterX merged commit eb3ed16 into ModelEngine-Group:1.2.x Jul 23, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from In review to Done in Nova Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: builder Issues in app-builder modules type: enhancement A general enhancement

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants