Skip to content

[app-builder] 去除不必要的AippErrCode.java文件#447

Merged
CodeCasterX merged 3 commits intoModelEngine-Group:1.2.xfrom
ZJUPJM:1.2.x-bugfix-remove-unnecessary-AippErrorCode
Sep 30, 2025
Merged

[app-builder] 去除不必要的AippErrCode.java文件#447
CodeCasterX merged 3 commits intoModelEngine-Group:1.2.xfrom
ZJUPJM:1.2.x-bugfix-remove-unnecessary-AippErrorCode

Conversation

@ZJUPJM
Copy link
Copy Markdown
Contributor

@ZJUPJM ZJUPJM commented Sep 22, 2025

🔗 相关问题 / Related Issue

Issue 链接 / Issue Link: #317 👈👈

  • 我已经创建了相关 Issue 并进行了讨论 / I have created and discussed the related issue
  • 这是一个微小的修改（如错别字），不需要 Issue / This is a trivial change (like typo fix) that doesn't need an issue

📋 变更类型 / Type of Change

  • 🐛 Bug 修复 / Bug fix (non-breaking change which fixes an issue)
  • ✨ 新功能 / New feature (non-breaking change which adds functionality)
  • 💥 破坏性变更 / Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 文档更新 / Documentation update
  • 🔧 重构 / Refactoring (no functional changes)
  • ⚡ 性能优化 / Performance improvement
  • 📦 依赖升级 / Dependency upgrade (update dependencies to newer versions)
  • 🚀 功能增强 / Feature enhancement (improve existing functionality without breaking changes)
  • 🧹 代码清理 / Code cleanup

📝 变更目的 / Purpose of the Change

AippErrCode.java错误码文件存在两份且大部分内容重复，将两份代码合并为一个，去除冗余代码

📋 主要变更 / Brief Changelog

  • 删除aipp-plugin下的AippErrCode.java文件
  • 将两个文件的非公共部分写入并保留在aipp-service下的AippErrCode.java文件中

🧪 验证变更 / Verifying this Change

测试步骤 / Test Steps

  1. 本地启动项目
  2. 编写手动测试案例进行测试
  3. 检查错误码是否生效

测试覆盖 / Test Coverage

  • 我已经添加了单元测试 / I have added unit tests
  • 所有现有测试都通过 / All existing tests pass
  • 我已经进行了手动测试 / I have performed manual testing

📸 截图 / Screenshots

请求成功：
image
image

资源不存在：
image

image

该应用已经成功发布过，无法修改名称：
image

image

✅ 贡献者检查清单 / Contributor Checklist

请确保你的 Pull Request 符合以下要求 / Please ensure your Pull Request meets the following requirements:

基本要求 / Basic Requirements:

  • 确保有 GitHub Issue 对应这个变更（微小变更如错别字除外）/ Make sure there is a Github issue filed for the change (trivial changes like typos excluded)
  • 你的 Pull Request 只解决一个 Issue，没有包含其他不相关的变更 / Your PR addresses just this issue, without pulling in other changes - one PR resolves one issue
  • PR 中的每个 commit 都有有意义的主题行和描述 / Each commit in the PR has a meaningful subject line and body

代码质量 / Code Quality:

  • 我的代码遵循项目的代码规范 / My code follows the project's coding standards
  • 我已经进行了自我代码审查 / I have performed a self-review of my code
  • 我已经为复杂的代码添加了必要的注释 / I have commented my code, particularly in hard-to-understand areas

测试要求 / Testing Requirements:

  • 我已经编写了必要的单元测试来验证逻辑正确性 / I have written necessary unit-tests to verify the logic correction
  • 当存在跨模块依赖时，我尽量使用了 mock / I have used mocks when cross-module dependencies exist
  • 基础检查通过：mvn -B clean package -Dmaven.test.skip=true，npm install --force && npm run build:pro / Basic checks pass
  • 单元测试通过：mvn clean install / Unit tests pass

文档和兼容性 / Documentation and Compatibility:

  • 我已经更新了相应的文档 / I have made corresponding changes to the documentation
  • 如果有破坏性变更，我已经在 PR 描述中详细说明 / If there are breaking changes, I have documented them in detail
  • 我已经考虑了向后兼容性 / I have considered backward compatibility

📋 附加信息 / Additional Notes

审查者注意事项 / Reviewer Notes:

@CodeCasterX CodeCasterX linked an issue Sep 29, 2025 that may be closed by this pull request
AippErrorCode.java文件存在两份 #317
Closed
4 tasks
@CodeCasterX CodeCasterX added in: builder Issues in app-builder modules type: task A general task labels Sep 29, 2025
@CodeCasterX CodeCasterX added this to the 1.2.4 milestone Sep 29, 2025
@desAweis desAweis requested a review from reeeborn33 September 30, 2025 02:01
@desAweis desAweis modified the milestones: 1.2.4, 1.3.0 Sep 30, 2025
@CodeCasterX CodeCasterX merged commit 40c4e5f into ModelEngine-Group:1.2.x Sep 30, 2025
1 check passed
desAweis pushed a commit to desAweis/app-platform that referenced this pull request Oct 9, 2025
@ZJUPJM @desAweis
[app-builder] 去除不必要的AippErrCode.java文件 (ModelEngine-Group#447)
0eb573f 
* [app-builder] 去除不必要的AippErrCode.java文件

* [app-builder] 错误信息国际化处理

* [app-builder] 错误信息国际化处理中文正确显示
CodeCasterX pushed a commit that referenced this pull request Oct 9, 2025
@desAweis @ZJUPJM @jsbjfkbsjk
解决 1.2.x 分支与 main 分支冲突 (#464)
a3dff7c 
* [app-builder] 去除不必要的AippErrCode.java文件 (#447)

* [app-builder] 去除不必要的AippErrCode.java文件

* [app-builder] 错误信息国际化处理

* [app-builder] 错误信息国际化处理中文正确显示

* 修复了应用复制后头像不显示和window系统不显示头像的问题 (#400)

* 修改了readme

* 修复了应用复制后头像没有被复制的issue

* 修复了应用复制后头像没有被复制的issue

---------

Co-authored-by: ZJUPJM <87301200+ZJUPJM@users.noreply.github.com>
Co-authored-by: Muggle <125979968+jsbjfkbsjk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reeeborn33 reeeborn33 reeeborn33 left review comments

@desAweis desAweis desAweis approved these changes

Assignees

@ZJUPJM ZJUPJM

Labels

in: builder Issues in app-builder modules type: task A general task

Projects

None yet

Milestone

1.2.4

Development

Successfully merging this pull request may close these issues.

AippErrorCode.java文件存在两份

4 participants

@ZJUPJM @desAweis @reeeborn33 @CodeCasterX