fix: replace 14 bare excepts with except Exception#2546
Merged
Conversation
Bare except catches KeyboardInterrupt and SystemExit, masking real errors.
WMC001
approved these changes
Mar 12, 2026
JasonW404
reviewed
Jun 24, 2026
| @@ -399,7 +399,7 @@ def __call__(self, task: str, **kwargs): | |||
| try: | |||
Member
There was a problem hiding this comment.
将 except: 替换为 except Exception: 是一个好的改进，但某些地方（如 core_agent.py:399）捕获所有异常后只记录空字符串，可能会掩盖重要错误信息。建议记录实际的异常信息，如 self.observer.add_message(self.name, ProcessType.AGENT_FINISH, str(e))。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace 14 bare
except:withexcept Exception:across 5 files. Bareexcept:catchesKeyboardInterruptandSystemExit, masking real errors.