♻️ Refactor: Optimize agent page layout & refactor agent generate page by xuyaqist · Pull Request #3020 · ModelEngine-Group/nexent

xuyaqist · 2026-05-25T06:19:54Z

No description provided.

This reverts commit d0aad14.

Copilot

Pull request overview

This PR refactors the Agents UI to a header-driven, two-column layout and extracts the agent prompt-generation flow into a dedicated hook with local cache restore. It also extends agent detail APIs/types to include per-agent edit permission, skills, and external A2A sub-agent relations to support the refactor.

Changes:

Refactored the Agents page layout (new fixed header selector + version panel) and migrated tabs to Radix UI tabs.
Extracted agent prompt generation into useAgentGeneration, added local cache restore in the store, and centralized read-only handling.
Extended agent detail payloads/types to include permission, skills, and external_sub_agent_id_list (backend + frontend).

Reviewed changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
frontend/types/auth.ts	Adds `getAccessibleGroupIds` to the authz context type.
frontend/types/agentConfig.ts	Introduces `AgentConfigUpdate` and adds `skills` / `external_sub_agent_id_list` to `Agent`.
frontend/styles/globals.css	Adjusts tool/skill tab widths and forces dropdown title content full-width.
frontend/stores/agentConfigStore.ts	Refactors dirty checking, adds generation state + cache restore, and consolidates update APIs.
frontend/services/agentConfigService.ts	Maps `permission` from agent detail response.
frontend/public/locales/zh/common.json	Updates a few strings and adds “generation completed for other agent” message.
frontend/public/locales/en/common.json	Updates a few strings and adds “generation completed for other agent” message.
frontend/package.json	Adds `@radix-ui/react-tabs` and reorders a couple dependencies.
frontend/lib/agentGenerationCache.ts	Simplifies generation cache structure and status setter.
frontend/hooks/useConfig.ts	Exposes `defaultLlmModelConfig` from app config.
frontend/hooks/group/useGroupList.ts	Returns `allGroupIds` and adds `useGroupDetails` filtering helper.
frontend/hooks/auth/useAuthorization.ts	Fetches tenant groups and exposes `getAccessibleGroupIds`.
frontend/hooks/agent/useAgentGeneration.ts	New: encapsulates prompt generation + streaming cache/update flow.
frontend/components/ui/tabs.tsx	New: Radix Tabs wrapper components.
frontend/components/ui/card.tsx	Removed: custom Card component (migrated to AntD Card).
frontend/components/agent/AgentImportWizard.tsx	Raises modal `zIndex` to avoid stacking issues.
frontend/components/agent/AgentCallRelationshipModal.tsx	Raises modal `zIndex` to avoid stacking issues.
frontend/app/[locale]/space/components/AgentCard.tsx	Fixes import path for `AgentCallRelationshipModal`.
frontend/app/[locale]/page.tsx	Migrates to AntD `Card` and adjusts card body styling.
frontend/app/[locale]/models/components/model/ModelAddDialog.tsx	Removes unused `isRerankModel`.
frontend/app/[locale]/agents/page.tsx	Replaces 3-column layout with Layout + new `AgentSelectorHeader` + version side panel.
frontend/app/[locale]/agents/components/AgentSelectorHeader.tsx	New: header agent selector + quick actions (copy/export/delete/import/version/manage/A2A).
frontend/app/[locale]/agents/components/agentManage/AgentList.tsx	Uses unified agent detail response (no manual permission merge).
frontend/app/[locale]/agents/components/agentManage/AgentCallRelationshipModal.tsx	Removed: old modal implementation (centralized component used instead).
frontend/app/[locale]/agents/components/AgentInfoComp.tsx	Removes version-manage props; reads `isGenerating` from store and simplifies header.
frontend/app/[locale]/agents/components/agentInfo/AgentGenerateDetail.tsx	Major refactor: Radix tabs, group filtering via auth hook, generation via `useAgentGeneration`, streaming display.
frontend/app/[locale]/agents/components/AgentConfigComp.tsx	Adds Radix tool/skill tabs and uses store `isReadOnly`.
frontend/app/[locale]/agents/components/agentConfig/ToolManagement.tsx	Adds `isReadOnly` prop and adjusts widths.
frontend/app/[locale]/agents/components/agentConfig/SkillManagement.tsx	Adds `isReadOnly` prop and adjusts widths.
frontend/app/[locale]/agents/components/agentConfig/CollaborativeAgent.tsx	Syncs external A2A relations into store external sub-agent IDs.
frontend/app/[locale]/agents/AgentVersionCard.tsx	Uses unified agent detail response (no manual permission merge).
backend/services/agent_service.py	Adds permission calculation, skills, and external sub-agent IDs to agent detail response.
backend/apps/agent_app.py	Passes `user_id` into agent detail impl so permission can be computed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# Conflicts: # frontend/app/[locale]/agents/components/agentConfig/SkillManagement.tsx # frontend/app/[locale]/agents/components/agentInfo/AgentGenerateDetail.tsx # frontend/types/agentConfig.ts # test/backend/app/test_agent_app.py

This reverts commit d5b7879.

This reverts commit 35f0821.

YehongPan · 2026-06-24T05:10:03Z

+            else:
+                ingroup_permission = agent_info.get("ingroup_permission")
+                agent_info["permission"] = ingroup_permission if ingroup_permission is not None else PERMISSION_READ
+        except Exception as e:


[代码规范] except Exception: 过于宽泛，建议捕获更具体的异常类型，避免掩盖潜在错误。

YehongPan · 2026-06-24T05:10:05Z

+            version_no=version_no
+        )
+        agent_info["skills"] = instances
+    except Exception as e:


[代码规范] except Exception: 过于宽泛，建议捕获更具体的异常类型，避免掩盖潜在错误。

YehongPan · 2026-06-24T05:10:06Z

+        agent_info["external_sub_agent_id_list"] = [
+            ea["external_agent_id"] for ea in external_agents
+        ]
+    except Exception as e:


[代码规范] except Exception: 过于宽泛，建议捕获更具体的异常类型，避免掩盖潜在错误。

xuyaqist added 8 commits May 19, 2026 12:42

修改单元测试

d0aad14

Revert "修改单元测试"

ddda2c4

This reverts commit d0aad14.

Merge branch 'develop' into xyq/refactor_agent_page

be7299d

Merge branch 'develop' into xyq/refactor_agent_page

af7d130

Merge branch 'develop' into xyq/refactor_agent_page

149de8e

Optimize agent page layout

7d936d4

Refactor agent generate page

cdadf61

Merge branch 'develop' into xyq/refactor_agent_page

091cd27

Copilot AI review requested due to automatic review settings May 25, 2026 06:19

xuyaqist requested review from Dallas98 and WMC001 as code owners May 25, 2026 06:19

Copilot started reviewing on behalf of xuyaqist May 25, 2026 06:20 View session

Copilot AI reviewed May 25, 2026

View reviewed changes

xuyaqist added 7 commits May 25, 2026 15:27

对于agent的currentAgentPermission状态进行统一处理，暴露isReadOnly

3039a2d

修复智能体生成页面，所有字段既由form item的name控制，又由streamValues控制

8168e23

更新i18n

d56c185

Merge branch 'develop' into xyq/refactor_agent_page

974852d

更新单元测试

2320bd0

更新api/agent/search_info返回的结果，新增skills，统一tools和skills

19c9c00

修复单元测试

f6ed5af

xuyaqist changed the title ~~Refactor: Optimize agent page layout & refactor agent generate page~~ ♻️ Refactor: Optimize agent page layout & refactor agent generate page May 25, 2026

WMC001 reviewed May 26, 2026

View reviewed changes

Comment thread frontend/public/locales/zh/common.json Outdated

WMC001 approved these changes May 26, 2026

View reviewed changes

xuyaqist added 7 commits May 26, 2026 14:13

Merge branch 'develop' into xyq/refactor_agent_page

06478e9

# Conflicts: # frontend/app/[locale]/agents/components/agentConfig/SkillManagement.tsx # frontend/app/[locale]/agents/components/agentInfo/AgentGenerateDetail.tsx # frontend/types/agentConfig.ts # test/backend/app/test_agent_app.py

解决冲突

49c905f

修复web编译失败问题

06da76b

处理在创建模式下智能体生成后无法保存的问题

e29f0a7

删除注释

d2a6527

优化代码

4c01f36

Merge branch 'develop' into xyq/refactor_agent_page

e826889

xuyaqist added 3 commits May 26, 2026 17:31

修复前端编译失败

2ad8beb

更新单元测试

8693fb2

更新单元测试

d5b7879

xuyaqist closed this May 26, 2026

xuyaqist reopened this May 26, 2026

xuyaqist closed this May 26, 2026

xuyaqist added 2 commits May 26, 2026 19:39

Revert "更新单元测试"

35f0821

This reverts commit d5b7879.

Reapply "更新单元测试"

9b5c5ee

This reverts commit 35f0821.

xuyaqist reopened this May 27, 2026

WMC001 approved these changes May 27, 2026

View reviewed changes

WMC001 merged commit e85f6a6 into develop May 27, 2026
19 of 34 checks passed

Dallas98 deleted the xyq/refactor_agent_page branch June 9, 2026 02:55

YehongPan reviewed Jun 24, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

♻️ Refactor: Optimize agent page layout & refactor agent generate page#3020

♻️ Refactor: Optimize agent page layout & refactor agent generate page#3020
WMC001 merged 27 commits into
developfrom
xyq/refactor_agent_page

xuyaqist commented May 25, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

YehongPan Jun 24, 2026

Uh oh!

YehongPan Jun 24, 2026

Uh oh!

YehongPan Jun 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

xuyaqist commented May 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

YehongPan Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

YehongPan Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

YehongPan Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants