🐛 Bugfix: knowledge_base_search_tool called with TypeError#3259
Merged
Conversation
…of type 'FieldInfo' is not iterable
WMC001
added a commit
that referenced
this pull request
Jun 18, 2026
* add_greeting_fields_to_agent-develop * feat(knowledge-base): add preserve_source_file and post-index source cleanup Let knowledge bases opt out of keeping uploaded MinIO copies after indexing while retaining Elasticsearch chunks for retrieval. Default behavior remains preserve_source_file=true for backward compatibility. - Add preserve_source_file column (init.sql + v2.2.0_0601 migration) - Accept preserve_source_file on create/update and northbound/vector APIs - Support document DELETE scope=source_only and source_available in listings - Run cleanup_source Celery task when preserve_source_file is false - UI: create-KB toggle, list tag, knowledge-base preview when copy is missing - Update vector-database SDK docs and backend tests * test(data_process): stub knowledge_db, redis_service, and redis in test_worker Align setup_mocks_for_worker with test_tasks so importing backend.data_process.worker loads package __init__ without real DB/redis deps. * test(data_process): shim cleanup_source for submit_process_forward_chain tests * remove duplicate import * fix: update unit tests for greeting_message and example_questions fields * add init.sql to sonar.properites * ♻️ Improvement: API to MCP conversion service supports configuring headers. (#3194) * ♻️ Improvement: API to MCP conversion service supports configuring headers. [Specification Details] 1. Front-end and back-end modifications * ♻️ Improvement: API to MCP conversion service supports configuring headers. [Specification Details] 1. Modify the frontend, after adding, set the HTTP headers to empty. 2. Modify test cases. * ♻️ Improvement: Enhance processing of ES index names in memory banks. (#3196) [Specification Details] 1. Replace all symbols in the index name that do not meet the rules with "_". 2. Modify test cases. * feat: add active memory tools (StoreMemoryTool, SearchMemoryTool) (#3197) - Implement StoreMemoryTool for explicit memory storage during agent reasoning - Implement SearchMemoryTool for on-demand memory retrieval during conversations - Integrate tools into agent creation flow (create_agent_info.py) - Register tools in nexent_agent.py and tools/__init__.py - Add MEMORY_OPERATION tool sign for proper categorization - Fix memory_core.py cache key to include event loop ID (prevents cross-loop conflicts) - Add comprehensive test coverage for both tools - Add procedural memory verification documentation Tools follow existing patterns: lazy imports, observer integration, error handling, and respect user memory preferences (agent_share_option, disabled_agent_ids). Co-authored-by: Dallas98 <40557804+Dallas98@users.noreply.github.com> * 🐛 Bugfix: skill names and descriptions never load to context (#3205) * 🐛 Bugfix: skill names and descriptions never load to context * 🐛 Bugfix: skill names and descriptions never load to context * 🐛 Bugfix: skill names and descriptions never load to context * 🐛 Bugfix: official skills not copied to target directory * 🐛 Bugfix: official skills not copied to target directory * Feat: add selected count badges to tool/skill pool labels (#3206) Co-authored-by: chase <byzhangxin11@126.com> * 🐛 Bugfix: Fix attribution error when tool calling error (#3208) * ✨ Feat: Add support for Word document generation, preview, and download (#3191) * Feat: Add support for Word document generation, preview, and download * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Restrict uploads to a known safe workspace/output directory * 修改单元测试 * 修复单元测试 * Bugfix: Store uploaded files in Minio for conversation messages to enable file visibility in history --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * ✨Feat:Enhance prompt optimization by integrating openjiuwen and fix related bugs (#3190) * ✨Feat：add prompt optimization * 🐛Bugfix: dockerbuild failed when running pipefail in python3_11 * 🔨Optimize： Optimize prompt optimization display page and interaction methods * 🐛Bugfix: fix dependencies replication * 🎨:Optimize frontend prompts and loading interface * 🔧 Refactor: Update imports and remove redundant ENABLE_JIUWEN_SDK import in prompt_service.py * 🔧 Refactor: Correct import path for NexentCapabilityError and enhance test coverage for prompt optimization service * 🔧 Refactor: Update import paths for exception handling and improve logging formatting in prompt_service.py * 🔧 Refactor: Simplify lazy imports in jiuwen_sdk_adapter.py and update import paths in prompt_service.py * 🔧 Refactor: Enhance Jiuwen SDK adapter handling and improve test stubs in prompt_service.py and related test files * 🧪test:Pydantic model for PromptTemplateRequest in test_prompt_template_app.py * 🔧 Refactor: Remove unnecessary dependency exclusions from pyproject.toml * 🔧 Update: Upgrade huggingface_hub dependency version in pyproject.toml * 🔧 Update: Exclude unnecessary transitive dependencies and adjust huggingface_hub version in pyproject.toml * 🔧 Test: Add mock modules for unstructured inference and set up package paths in test files * 🔧 Test: Enhance test setup by adding optional SDK mocks and cleaning up module imports in data processing tests * 🔧 Test: Consolidate mock module setup for unstructured inference across multiple test files * 🔧 Test: Remove unused optional SDK mocks from test configuration * 🔧 Refactor: Clean up imports and enhance dynamic loading of fastmcp components in Docker client * 📦update:sdk dependence update * Add CAS SSO integration and improve logout handling (#3072) * feat: add CAS SSO integration * Skip CAS logout when CAS_LOGOUT_URL is unset * 取消转义 * Improve CAS logout handling and confirm user logout * Disable account deletion for CAS users * Add CAS session init SQL and k8s config * clean code * Remove agent guardrails design doc from tracking * 补充文档 --------- Co-authored-by: hhhhsc <name> * 🐛Bugfix: Remove unnecessary dependency exclusions and upgrade huggingface_hub version in pyproject.toml (#3211) * refactor: move current time from system prompt to user message for prompt cache stability (#3203) Remove {{time}} from all 4 prompt YAML templates (manager/managed × en/zh) and strip time_str from the context_utils pipeline (_format_app_context, build_skeleton_header_component, build_context_components, build_app_context_string). Also remove time from create_agent_info render kwargs and build_context_components call. In CoreAgent.run, prepend [Current time: ...] to self.task so the timestamp travels with the user message instead of being baked into the system prompt. This makes the rendered system prompt fully deterministic per (agent_id, tenant_id, version_no, language) — enabling prompt/KV cache hits across requests for the same agent config. Sync test_context_utils.py: drop time_str= from 3 test cases. Remove unused datetime imports from context_utils.py and create_agent_info.py. * 🐛 Bugfix: Fixed the issue of being unable to add MCP services via containerization. (#3213) [Specification Details] 1. Modify the DEFAULT_NETWORK_NAME when starting the MCP service in the container to match the name in docker-compose. 2. Modify the parameters passed to the add_mcp_service method; custom_headers defaults to None. * 🐛 Bugfix: Fixed the issue where uploaded text files could not be parsed during a session. (#3219) * 🐛 Bugfix: Fixed the issue where uploaded text files could not be parsed during a session. [Specification Details] 1. The return parameter of the file_process method has changed and needs to be unpacked. * 🐛 Bugfix: Fixed the issue where uploaded text files could not be parsed during a session. [Specification Details] 1. Modify test case. * 🐛 Bugfix: Fixed an issue where the MCP service could not be added correctly after updating the FastMCP version. (#3222) [Specification Details] 1. Add `kwargs` to the `create_httpx_client` function to accept all additional parameters. * 🐛 Bugfix: Fix incomplete display of tenant resources page after window resize (#3215) * Move non-shadcn ui component to other folder * Bugfix: Fix incomplete display of tenant resources page after window resize * Bugfix: Fix incomplete display of tenant resources page after window resize * Add agent marketplace repository and version pinning for sub-agents (#3239) * feat: add agent marketplace repository and pin sub-agent versions at publish Introduce ag_agent_repository_t with list/status/publish/import APIs for frozen agent snapshots. Pin selected_agent_version_no on agent relations when publishing so sub-agents resolve to a fixed version at runtime. Extend agent export/import to bundle skills in ZIP payloads and add embedding model fallback when no model name is provided. * feat: add agent marketplace repository and pin sub-agent versions at publish Introduce ag_agent_repository_t with list/status/publish/import APIs for frozen agent snapshots. Pin selected_agent_version_no on agent relations when publishing so sub-agents resolve to a fixed version at runtime. Extend agent export/import to bundle skills in ZIP payloads and add embedding model fallback when no model name is provided. * feat: add agent marketplace repository and pin sub-agent versions at publish Introduce ag_agent_repository_t with list/status/publish/import APIs for frozen agent snapshots. Pin selected_agent_version_no on agent relations when publishing so sub-agents resolve to a fixed version at runtime. Extend agent export/import to bundle skills in ZIP payloads and add embedding model fallback when no model name is provided. * feat: add agent marketplace repository and pin sub-agent versions at publish Introduce ag_agent_repository_t with list/status/publish/import APIs for frozen agent snapshots. Pin selected_agent_version_no on agent relations when publishing so sub-agents resolve to a fixed version at runtime. Extend agent export/import to bundle skills in ZIP payloads and add embedding model fallback when no model name is provided. * feat(agent): add verification configuration for agents and update related components (#3174) * feat(agent): add verification configuration for agents and update related components * feat(model): update model type labels and add monitoring dashboard translations * 🐛 Bugfix: Fix inability to select agent from agent space to edit (#3240) * Move non-shadcn ui component to other folder * Bugfix: Fix incomplete display of tenant resources page after window resize * Bugfix: Fix incomplete display of tenant resources page after window resize * Bugfix: Fix inability to select agent from agent space to edit * Bugfix: Display correct version info when viewing agent details * Update data agent and ME CAS integration documentation (#3242) * 补充dataagent对接文档 * 补充ME cas对接文档 * 补充ME cas对接文档 --------- Co-authored-by: hhhhsc <name> * ✨ Add several northbound apis (#3223) * ✨ Add several northbound apis * ✨ Add several northbound apis * ✨ Add several northbound apis * ✨ Add several northbound apis * ✨ Add several northbound apis * refactor: simplify deployment script by removing unused variables and functions (#3245) * feat(agent): add verification configuration for agents and update related components * feat(model): update model type labels and add monitoring dashboard translations * refactor(build_offline_package): simplify deployment script by removing unused variables and functions * 🐛 Bugfix: Adjust agent detail UI layout to accommodate newly added "self-verification" field (#3246) * Move non-shadcn ui component to other folder * Bugfix: Fix incomplete display of tenant resources page after window resize * Bugfix: Fix incomplete display of tenant resources page after window resize * Bugfix: Fix inability to select agent from agent space to edit * Bugfix: Display correct version info when viewing agent details * Bugfix: Adjust agent detail UI layout to accommodate newly added "self-verification" field * 补充sql (#3248) * 补充sql * 扩大limit限制 * 🐛 Bugfix: Fixed an issue where the MCP service failed to start in a Kubernetes container. (#3254) [Specification Details] 1. Modify the pod naming logic to convert all non-compliant characters to -. 2. Modify test cases. * 🐛 Bugfix: knowledge_base_search_tool called with TypeError: argument of type 'FieldInfo' is not iterable (#3259) * 🐛 Bugfix: Fixed an issue where the one-click rename function failed after importing an agent. (#3258) [Specification Details] 1. The frontend does not pass `agent_id` when calling the `regenerate_name` API. * Bugfix: Exclude attachments from assistant when saving conversation history (#3261) * Bump APP_VERSION from v2.2.0 to v2.2.1 (#3268) The default setting for client-side self-validation is "False". --------- Co-authored-by: chase <byzhangxin11@126.com> Co-authored-by: Chenlifeng <174292121+Lifeng-Chen@users.noreply.github.com> Co-authored-by: Dallas98 <40557804+Dallas98@users.noreply.github.com> Co-authored-by: Jason Wang <56037774+JasonW404@users.noreply.github.com> Co-authored-by: Xia Yichen <iamjasonxia@126.com> Co-authored-by: JeffWu <45140512+jeffwu-1999@users.noreply.github.com> Co-authored-by: WMC001 <46217886+WMC001@users.noreply.github.com> Co-authored-by: xuyaqi <xuyaqist@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: DongJiBao2001 <120021235+DongJiBao2001@users.noreply.github.com> Co-authored-by: hhhhsc701 <56435672+hhhhsc701@users.noreply.github.com> Co-authored-by: Dallas98 <990259227@qq.com> Co-authored-by: frr <64584192+wuyuanfr@users.noreply.github.com>
WMC001
pushed a commit
that referenced
this pull request
Jun 18, 2026
* 🐛 Bugfix: Adjust agent detail UI layout to accommodate newly added "self-verification" field (#3246) * Move non-shadcn ui component to other folder * Bugfix: Fix incomplete display of tenant resources page after window resize * Bugfix: Fix incomplete display of tenant resources page after window resize * Bugfix: Fix inability to select agent from agent space to edit * Bugfix: Display correct version info when viewing agent details * Bugfix: Adjust agent detail UI layout to accommodate newly added "self-verification" field * 补充sql (#3248) * 补充sql * 扩大limit限制 * 🐛 Bugfix: Fixed an issue where the MCP service failed to start in a Kubernetes container. (#3254) [Specification Details] 1. Modify the pod naming logic to convert all non-compliant characters to -. 2. Modify test cases. * 🐛 Bugfix: knowledge_base_search_tool called with TypeError: argument of type 'FieldInfo' is not iterable (#3259) * 🐛 Bugfix: Fixed an issue where the one-click rename function failed after importing an agent. (#3258) [Specification Details] 1. The frontend does not pass `agent_id` when calling the `regenerate_name` API. * Bugfix: Exclude attachments from assistant when saving conversation history (#3261) * Bump APP_VERSION from v2.2.0 to v2.2.1 (#3268) The default setting for client-side self-validation is "False". --------- Co-authored-by: xuyaqi <xuyaqist@gmail.com> Co-authored-by: hhhhsc701 <56435672+hhhhsc701@users.noreply.github.com> Co-authored-by: Xia Yichen <iamjasonxia@126.com>
WMC001
added a commit
that referenced
this pull request
Jun 18, 2026
* 🐛 Bugfix: Adjust agent detail UI layout to accommodate newly added "self-verification" field (#3246) * Move non-shadcn ui component to other folder * Bugfix: Fix incomplete display of tenant resources page after window resize * Bugfix: Fix incomplete display of tenant resources page after window resize * Bugfix: Fix inability to select agent from agent space to edit * Bugfix: Display correct version info when viewing agent details * Bugfix: Adjust agent detail UI layout to accommodate newly added "self-verification" field * 补充sql (#3248) * 补充sql * 扩大limit限制 * 🐛 Bugfix: Fixed an issue where the MCP service failed to start in a Kubernetes container. (#3254) [Specification Details] 1. Modify the pod naming logic to convert all non-compliant characters to -. 2. Modify test cases. * 🐛 Bugfix: knowledge_base_search_tool called with TypeError: argument of type 'FieldInfo' is not iterable (#3259) * 🐛 Bugfix: Fixed an issue where the one-click rename function failed after importing an agent. (#3258) [Specification Details] 1. The frontend does not pass `agent_id` when calling the `regenerate_name` API. * Bugfix: Exclude attachments from assistant when saving conversation history (#3261) * Bump APP_VERSION from v2.2.0 to v2.2.1 (#3268) The default setting for client-side self-validation is "False". --------- Co-authored-by: xuyaqi <xuyaqist@gmail.com> Co-authored-by: hhhhsc701 <56435672+hhhhsc701@users.noreply.github.com> Co-authored-by: Xia Yichen <iamjasonxia@126.com>
xuyaqist
pushed a commit
that referenced
this pull request
Jun 22, 2026
…of type 'FieldInfo' is not iterable (#3259)
JasonW404
reviewed
Jun 24, 2026
| Filtered list containing only results with allowed document paths | ||
| """ | ||
| allowed_paths = self._internal_document_paths | ||
| allowed_paths = _unwrap_field_info(self._internal_document_paths) |
Member
There was a problem hiding this comment.
_unwrap_field_info 被调用了 3 次（__init__、set_document_paths、_filter_by_document_paths），每次都对同一个属性做类型检查。建议在 __init__ 和 set_document_paths 中 unwrap 后存储为普通值，_filter_by_document_paths 就不需要再 unwrap 了。当前的防御性重复调用虽然安全，但增加了理解成本。
YehongPan
reviewed
Jun 24, 2026
| Filtered list containing only results with allowed document paths | ||
| """ | ||
| allowed_paths = self._internal_document_paths | ||
| allowed_paths = _unwrap_field_info(self._internal_document_paths) |
Contributor
There was a problem hiding this comment.
[代码规范] _unwrap_field_info 在 _filter_by_document_paths 中每次调用时都被重复执行，但 self._internal_document_paths 在 __init__ 和 set_document_paths 中已经被 unwrap 过了。建议在赋值时就保证值是 unwrap 的，此处无需再次调用，避免不必要的运行时开销，也让数据流更清晰。
Jasonxia007
commented
Jun 24, 2026
Jasonxia007
left a comment
Jasonxia007
left a comment
Contributor
Author
There was a problem hiding this comment.
PR Review Summary
🔴 Critical (1)
- #3259:
knowledge_base_search_tool被调用时传入FieldInfo而非实际参数值（argument of type 'FieldInfo' is not iterable）。根因：kwargs中未过滤 Pydantic FieldInfo，直接透传导致类型错误。
关联 Cursor Rules: Backend Service Layer — 应在调用侧做参数预处理，不应将 Pydantic 元对象透传到下游 SDK。
xuyaqist
reviewed
Jun 25, 2026
| logger = logging.getLogger("knowledge_base_search_tool") | ||
|
|
||
|
|
||
| def _unwrap_field_info(value): |
Contributor
There was a problem hiding this comment.
_unwrap_field_info 只处理了 FieldInfo 的一层包装。如果存在嵌套的 FieldInfo（例如 Field(default=Field(default=...))），当前实现无法递归解包。虽然目前不太可能出现嵌套情况，但建议在函数文档中明确说明仅支持单层解包，或添加递归处理。
xuyaqist
reviewed
Jun 25, 2026
| Filtered list containing only results with allowed document paths | ||
| """ | ||
| allowed_paths = self._internal_document_paths | ||
| allowed_paths = _unwrap_field_info(self._internal_document_paths) |
Contributor
There was a problem hiding this comment.
在 _filter_by_document_paths 中每次都调用 _unwrap_field_info 来解包 self._internal_document_paths，但正常情况下该值在 __init__ 或 set_document_paths 中已经被解包过了。这里的重复解包是不必要的性能开销。建议只在 set_document_paths 和 __init__ 中解包一次，此处直接使用 self._internal_document_paths。
hhhhsc701
reviewed
Jun 25, 2026
| """ | ||
| if isinstance(value, FieldInfo): | ||
| if value.default_factory is not None: | ||
| return value.default_factory() |
Contributor
There was a problem hiding this comment.
[P2] default_factory 每次 unwrap 都会执行，包括过滤阶段再次调用时。如果 factory 生成的是可变列表或有副作用，允许列表会在一次请求内变化；建议在 init/set_document_paths 时解析一次并缓存具体值。
| if value.default_factory is not None: | ||
| return value.default_factory() | ||
| return value.default | ||
| return value |
Contributor
There was a problem hiding this comment.
[P1] 这里直接返回原值，没有保证 document_paths 是 list[str]。如果外部传入字符串，后续 membership 会变成对子串的检查，可能错误放行或丢弃结果；需要显式校验/转换类型。
| document_paths: List of allowed document path_or_urls. If None, no filtering is applied. | ||
| """ | ||
| self._internal_document_paths = document_paths | ||
| self._internal_document_paths = _unwrap_field_info(document_paths) |
Contributor
There was a problem hiding this comment.
[P1] set_document_paths 仍然接受任意值并直接保存 unwrap 结果。这个字段承担访问控制，不能只处理 FieldInfo；应该拒绝非 list[str]，并把空列表保留为“禁止所有文档”而不是 None。
| Filtered list containing only results with allowed document paths | ||
| """ | ||
| allowed_paths = self._internal_document_paths | ||
| allowed_paths = _unwrap_field_info(self._internal_document_paths) |
Contributor
There was a problem hiding this comment.
[P1] 过滤前没有把 path_or_url 和 allowed_paths 规范到同一种对象路径。s3://、/nexent/、presigned URL 三种形式会互相不匹配，访问控制结果取决于上游返回格式。
| # may populate this; never the LLM. | ||
| tools_obj.set_document_paths( | ||
| tool_config.metadata.get( | ||
| "document_paths") if tool_config.metadata else None |
Contributor
There was a problem hiding this comment.
[P1] metadata 里的 document_paths 被直接送进访问控制过滤器，没有校验来源和类型。只要 metadata 被错误构造为字符串或混合 URL，就会影响检索授权；这里应在 agent 侧先 validate/canonicalize。
hhhhsc701
reviewed
Jun 26, 2026
| """ | ||
| if isinstance(value, FieldInfo): | ||
| if value.default_factory is not None: | ||
| return value.default_factory() |
Contributor
There was a problem hiding this comment.
[P2] default_factory 每次 unwrap 都会执行，包括过滤阶段再次调用时。如果 factory 生成的是可变列表或有副作用，允许列表会在一次请求内变化；建议在 init/set_document_paths 时解析一次并缓存具体值。
hhhhsc701
reviewed
Jun 26, 2026
| if value.default_factory is not None: | ||
| return value.default_factory() | ||
| return value.default | ||
| return value |
Contributor
There was a problem hiding this comment.
[P1] 这里直接返回原值，没有保证 document_paths 是 list[str]。如果外部传入字符串，后续 membership 会变成对子串的检查，可能错误放行或丢弃结果；需要显式校验/转换类型。
hhhhsc701
reviewed
Jun 26, 2026
| document_paths: List of allowed document path_or_urls. If None, no filtering is applied. | ||
| """ | ||
| self._internal_document_paths = document_paths | ||
| self._internal_document_paths = _unwrap_field_info(document_paths) |
Contributor
There was a problem hiding this comment.
[P1] set_document_paths 仍然接受任意值并直接保存 unwrap 结果。这个字段承担访问控制，不能只处理 FieldInfo；应该拒绝非 list[str]，并把空列表保留为“禁止所有文档”而不是 None。
hhhhsc701
reviewed
Jun 26, 2026
| Filtered list containing only results with allowed document paths | ||
| """ | ||
| allowed_paths = self._internal_document_paths | ||
| allowed_paths = _unwrap_field_info(self._internal_document_paths) |
Contributor
There was a problem hiding this comment.
[P1] 过滤前没有把 path_or_url 和 allowed_paths 规范到同一种对象路径。s3://、/nexent/、presigned URL 三种形式会互相不匹配，访问控制结果取决于上游返回格式。
hhhhsc701
reviewed
Jun 26, 2026
| # may populate this; never the LLM. | ||
| tools_obj.set_document_paths( | ||
| tool_config.metadata.get( | ||
| "document_paths") if tool_config.metadata else None |
Contributor
There was a problem hiding this comment.
[P1] metadata 里的 document_paths 被直接送进访问控制过滤器，没有校验来源和类型。只要 metadata 被错误构造为字符串或混合 URL，就会影响检索授权；这里应在 agent 侧先 validate/canonicalize。
WMC001
added a commit
that referenced
this pull request
Jun 26, 2026
* Release/v2.2.1 (#3269) * add_greeting_fields_to_agent-develop * feat(knowledge-base): add preserve_source_file and post-index source cleanup Let knowledge bases opt out of keeping uploaded MinIO copies after indexing while retaining Elasticsearch chunks for retrieval. Default behavior remains preserve_source_file=true for backward compatibility. - Add preserve_source_file column (init.sql + v2.2.0_0601 migration) - Accept preserve_source_file on create/update and northbound/vector APIs - Support document DELETE scope=source_only and source_available in listings - Run cleanup_source Celery task when preserve_source_file is false - UI: create-KB toggle, list tag, knowledge-base preview when copy is missing - Update vector-database SDK docs and backend tests * test(data_process): stub knowledge_db, redis_service, and redis in test_worker Align setup_mocks_for_worker with test_tasks so importing backend.data_process.worker loads package __init__ without real DB/redis deps. * test(data_process): shim cleanup_source for submit_process_forward_chain tests * remove duplicate import * fix: update unit tests for greeting_message and example_questions fields * add init.sql to sonar.properites * ♻️ Improvement: API to MCP conversion service supports configuring headers. (#3194) * ♻️ Improvement: API to MCP conversion service supports configuring headers. [Specification Details] 1. Front-end and back-end modifications * ♻️ Improvement: API to MCP conversion service supports configuring headers. [Specification Details] 1. Modify the frontend, after adding, set the HTTP headers to empty. 2. Modify test cases. * ♻️ Improvement: Enhance processing of ES index names in memory banks. (#3196) [Specification Details] 1. Replace all symbols in the index name that do not meet the rules with "_". 2. Modify test cases. * feat: add active memory tools (StoreMemoryTool, SearchMemoryTool) (#3197) - Implement StoreMemoryTool for explicit memory storage during agent reasoning - Implement SearchMemoryTool for on-demand memory retrieval during conversations - Integrate tools into agent creation flow (create_agent_info.py) - Register tools in nexent_agent.py and tools/__init__.py - Add MEMORY_OPERATION tool sign for proper categorization - Fix memory_core.py cache key to include event loop ID (prevents cross-loop conflicts) - Add comprehensive test coverage for both tools - Add procedural memory verification documentation Tools follow existing patterns: lazy imports, observer integration, error handling, and respect user memory preferences (agent_share_option, disabled_agent_ids). Co-authored-by: Dallas98 <40557804+Dallas98@users.noreply.github.com> * 🐛 Bugfix: skill names and descriptions never load to context (#3205) * 🐛 Bugfix: skill names and descriptions never load to context * 🐛 Bugfix: skill names and descriptions never load to context * 🐛 Bugfix: skill names and descriptions never load to context * 🐛 Bugfix: official skills not copied to target directory * 🐛 Bugfix: official skills not copied to target directory * Feat: add selected count badges to tool/skill pool labels (#3206) Co-authored-by: chase <byzhangxin11@126.com> * 🐛 Bugfix: Fix attribution error when tool calling error (#3208) * ✨ Feat: Add support for Word document generation, preview, and download (#3191) * Feat: Add support for Word document generation, preview, and download * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Restrict uploads to a known safe workspace/output directory * 修改单元测试 * 修复单元测试 * Bugfix: Store uploaded files in Minio for conversation messages to enable file visibility in history --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * ✨Feat:Enhance prompt optimization by integrating openjiuwen and fix related bugs (#3190) * ✨Feat：add prompt optimization * 🐛Bugfix: dockerbuild failed when running pipefail in python3_11 * 🔨Optimize： Optimize prompt optimization display page and interaction methods * 🐛Bugfix: fix dependencies replication * 🎨:Optimize frontend prompts and loading interface * 🔧 Refactor: Update imports and remove redundant ENABLE_JIUWEN_SDK import in prompt_service.py * 🔧 Refactor: Correct import path for NexentCapabilityError and enhance test coverage for prompt optimization service * 🔧 Refactor: Update import paths for exception handling and improve logging formatting in prompt_service.py * 🔧 Refactor: Simplify lazy imports in jiuwen_sdk_adapter.py and update import paths in prompt_service.py * 🔧 Refactor: Enhance Jiuwen SDK adapter handling and improve test stubs in prompt_service.py and related test files * 🧪test:Pydantic model for PromptTemplateRequest in test_prompt_template_app.py * 🔧 Refactor: Remove unnecessary dependency exclusions from pyproject.toml * 🔧 Update: Upgrade huggingface_hub dependency version in pyproject.toml * 🔧 Update: Exclude unnecessary transitive dependencies and adjust huggingface_hub version in pyproject.toml * 🔧 Test: Add mock modules for unstructured inference and set up package paths in test files * 🔧 Test: Enhance test setup by adding optional SDK mocks and cleaning up module imports in data processing tests * 🔧 Test: Consolidate mock module setup for unstructured inference across multiple test files * 🔧 Test: Remove unused optional SDK mocks from test configuration * 🔧 Refactor: Clean up imports and enhance dynamic loading of fastmcp components in Docker client * 📦update:sdk dependence update * Add CAS SSO integration and improve logout handling (#3072) * feat: add CAS SSO integration * Skip CAS logout when CAS_LOGOUT_URL is unset * 取消转义 * Improve CAS logout handling and confirm user logout * Disable account deletion for CAS users * Add CAS session init SQL and k8s config * clean code * Remove agent guardrails design doc from tracking * 补充文档 --------- Co-authored-by: hhhhsc <name> * 🐛Bugfix: Remove unnecessary dependency exclusions and upgrade huggingface_hub version in pyproject.toml (#3211) * refactor: move current time from system prompt to user message for prompt cache stability (#3203) Remove {{time}} from all 4 prompt YAML templates (manager/managed × en/zh) and strip time_str from the context_utils pipeline (_format_app_context, build_skeleton_header_component, build_context_components, build_app_context_string). Also remove time from create_agent_info render kwargs and build_context_components call. In CoreAgent.run, prepend [Current time: ...] to self.task so the timestamp travels with the user message instead of being baked into the system prompt. This makes the rendered system prompt fully deterministic per (agent_id, tenant_id, version_no, language) — enabling prompt/KV cache hits across requests for the same agent config. Sync test_context_utils.py: drop time_str= from 3 test cases. Remove unused datetime imports from context_utils.py and create_agent_info.py. * 🐛 Bugfix: Fixed the issue of being unable to add MCP services via containerization. (#3213) [Specification Details] 1. Modify the DEFAULT_NETWORK_NAME when starting the MCP service in the container to match the name in docker-compose. 2. Modify the parameters passed to the add_mcp_service method; custom_headers defaults to None. * 🐛 Bugfix: Fixed the issue where uploaded text files could not be parsed during a session. (#3219) * 🐛 Bugfix: Fixed the issue where uploaded text files could not be parsed during a session. [Specification Details] 1. The return parameter of the file_process method has changed and needs to be unpacked. * 🐛 Bugfix: Fixed the issue where uploaded text files could not be parsed during a session. [Specification Details] 1. Modify test case. * 🐛 Bugfix: Fixed an issue where the MCP service could not be added correctly after updating the FastMCP version. (#3222) [Specification Details] 1. Add `kwargs` to the `create_httpx_client` function to accept all additional parameters. * 🐛 Bugfix: Fix incomplete display of tenant resources page after window resize (#3215) * Move non-shadcn ui component to other folder * Bugfix: Fix incomplete display of tenant resources page after window resize * Bugfix: Fix incomplete display of tenant resources page after window resize * Add agent marketplace repository and version pinning for sub-agents (#3239) * feat: add agent marketplace repository and pin sub-agent versions at publish Introduce ag_agent_repository_t with list/status/publish/import APIs for frozen agent snapshots. Pin selected_agent_version_no on agent relations when publishing so sub-agents resolve to a fixed version at runtime. Extend agent export/import to bundle skills in ZIP payloads and add embedding model fallback when no model name is provided. * feat: add agent marketplace repository and pin sub-agent versions at publish Introduce ag_agent_repository_t with list/status/publish/import APIs for frozen agent snapshots. Pin selected_agent_version_no on agent relations when publishing so sub-agents resolve to a fixed version at runtime. Extend agent export/import to bundle skills in ZIP payloads and add embedding model fallback when no model name is provided. * feat: add agent marketplace repository and pin sub-agent versions at publish Introduce ag_agent_repository_t with list/status/publish/import APIs for frozen agent snapshots. Pin selected_agent_version_no on agent relations when publishing so sub-agents resolve to a fixed version at runtime. Extend agent export/import to bundle skills in ZIP payloads and add embedding model fallback when no model name is provided. * feat: add agent marketplace repository and pin sub-agent versions at publish Introduce ag_agent_repository_t with list/status/publish/import APIs for frozen agent snapshots. Pin selected_agent_version_no on agent relations when publishing so sub-agents resolve to a fixed version at runtime. Extend agent export/import to bundle skills in ZIP payloads and add embedding model fallback when no model name is provided. * feat(agent): add verification configuration for agents and update related components (#3174) * feat(agent): add verification configuration for agents and update related components * feat(model): update model type labels and add monitoring dashboard translations * 🐛 Bugfix: Fix inability to select agent from agent space to edit (#3240) * Move non-shadcn ui component to other folder * Bugfix: Fix incomplete display of tenant resources page after window resize * Bugfix: Fix incomplete display of tenant resources page after window resize * Bugfix: Fix inability to select agent from agent space to edit * Bugfix: Display correct version info when viewing agent details * Update data agent and ME CAS integration documentation (#3242) * 补充dataagent对接文档 * 补充ME cas对接文档 * 补充ME cas对接文档 --------- Co-authored-by: hhhhsc <name> * ✨ Add several northbound apis (#3223) * ✨ Add several northbound apis * ✨ Add several northbound apis * ✨ Add several northbound apis * ✨ Add several northbound apis * ✨ Add several northbound apis * refactor: simplify deployment script by removing unused variables and functions (#3245) * feat(agent): add verification configuration for agents and update related components * feat(model): update model type labels and add monitoring dashboard translations * refactor(build_offline_package): simplify deployment script by removing unused variables and functions * 🐛 Bugfix: Adjust agent detail UI layout to accommodate newly added "self-verification" field (#3246) * Move non-shadcn ui component to other folder * Bugfix: Fix incomplete display of tenant resources page after window resize * Bugfix: Fix incomplete display of tenant resources page after window resize * Bugfix: Fix inability to select agent from agent space to edit * Bugfix: Display correct version info when viewing agent details * Bugfix: Adjust agent detail UI layout to accommodate newly added "self-verification" field * 补充sql (#3248) * 补充sql * 扩大limit限制 * 🐛 Bugfix: Fixed an issue where the MCP service failed to start in a Kubernetes container. (#3254) [Specification Details] 1. Modify the pod naming logic to convert all non-compliant characters to -. 2. Modify test cases. * 🐛 Bugfix: knowledge_base_search_tool called with TypeError: argument of type 'FieldInfo' is not iterable (#3259) * 🐛 Bugfix: Fixed an issue where the one-click rename function failed after importing an agent. (#3258) [Specification Details] 1. The frontend does not pass `agent_id` when calling the `regenerate_name` API. * Bugfix: Exclude attachments from assistant when saving conversation history (#3261) * Bump APP_VERSION from v2.2.0 to v2.2.1 (#3268) The default setting for client-side self-validation is "False". --------- Co-authored-by: chase <byzhangxin11@126.com> Co-authored-by: Chenlifeng <174292121+Lifeng-Chen@users.noreply.github.com> Co-authored-by: Dallas98 <40557804+Dallas98@users.noreply.github.com> Co-authored-by: Jason Wang <56037774+JasonW404@users.noreply.github.com> Co-authored-by: Xia Yichen <iamjasonxia@126.com> Co-authored-by: JeffWu <45140512+jeffwu-1999@users.noreply.github.com> Co-authored-by: WMC001 <46217886+WMC001@users.noreply.github.com> Co-authored-by: xuyaqi <xuyaqist@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: DongJiBao2001 <120021235+DongJiBao2001@users.noreply.github.com> Co-authored-by: hhhhsc701 <56435672+hhhhsc701@users.noreply.github.com> Co-authored-by: Dallas98 <990259227@qq.com> Co-authored-by: frr <64584192+wuyuanfr@users.noreply.github.com> * Revert "Release/v2.2.1 (#3269)" (#3272) This reverts commit 9ff420e. * ✨ Feature: add agent repository page and APIs Introduce Agent Repository backend APIs, database/service support, frontend views, client services, and tests. Migrate Agent Space navigation and permissions to /agent-repository with updated SQL and localization. * ✨ Feature: add agent repository page and APIs Introduce Agent Repository backend APIs, database/service support, frontend views, client services, and tests. Migrate Agent Space navigation and permissions to /agent-repository with updated SQL and localization. * ✨ Feature: add agent repository page and APIs Introduce Agent Repository backend APIs, database/service support, frontend views, client services, and tests. Migrate Agent Space navigation and permissions to /agent-repository with updated SQL and localization. * ✨ Feature: add agent repository page and APIs Introduce Agent Repository backend APIs, database/service support, frontend views, client services, and tests. Migrate Agent Space navigation and permissions to /agent-repository with updated SQL and localization. * ✨ Feature: add agent repository page and APIs Introduce Agent Repository backend APIs, database/service support, frontend views, client services, and tests. Migrate Agent Space navigation and permissions to /agent-repository with updated SQL and localization. --------- Co-authored-by: panyehong <91180085+YehongPan@users.noreply.github.com> Co-authored-by: chase <byzhangxin11@126.com> Co-authored-by: Dallas98 <40557804+Dallas98@users.noreply.github.com> Co-authored-by: Jason Wang <56037774+JasonW404@users.noreply.github.com> Co-authored-by: Xia Yichen <iamjasonxia@126.com> Co-authored-by: JeffWu <45140512+jeffwu-1999@users.noreply.github.com> Co-authored-by: WMC001 <46217886+WMC001@users.noreply.github.com> Co-authored-by: xuyaqi <xuyaqist@gmail.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: DongJiBao2001 <120021235+DongJiBao2001@users.noreply.github.com> Co-authored-by: hhhhsc701 <56435672+hhhhsc701@users.noreply.github.com> Co-authored-by: Dallas98 <990259227@qq.com> Co-authored-by: frr <64584192+wuyuanfr@users.noreply.github.com>
Dallas98
reviewed
Jun 29, 2026
Dallas98
left a comment
Dallas98
left a comment
Member
There was a problem hiding this comment.
事后审查补充：按已合入 diff 补充 5 条可行动 inline review comments。
| """ | ||
| if isinstance(value, FieldInfo): | ||
| if value.default_factory is not None: | ||
| return value.default_factory() |
Member
There was a problem hiding this comment.
事后审查补充：[P2] default_factory 每次 unwrap 都会执行，包括过滤阶段再次调用时。如果 factory 生成的是可变列表或有副作用，允许列表会在一次请求内变化；建议在 init/set_document_paths 时解析一次并缓存具体值。
影响：这个问题合入后会在对应部署、运行或权限场景中留下真实故障/安全风险，后续排查成本较高。
建议：沿着上述风险点补齐校验、配置来源、权限边界或回归测试，避免同类问题再次出现。
| if value.default_factory is not None: | ||
| return value.default_factory() | ||
| return value.default | ||
| return value |
Member
There was a problem hiding this comment.
事后审查补充：[P1] 这里直接返回原值，没有保证 document_paths 是 list[str]。如果外部传入字符串，后续 membership 会变成对子串的检查，可能错误放行或丢弃结果；需要显式校验/转换类型。
影响：这个问题合入后会在对应部署、运行或权限场景中留下真实故障/安全风险，后续排查成本较高。
建议：沿着上述风险点补齐校验、配置来源、权限边界或回归测试，避免同类问题再次出现。
| document_paths: List of allowed document path_or_urls. If None, no filtering is applied. | ||
| """ | ||
| self._internal_document_paths = document_paths | ||
| self._internal_document_paths = _unwrap_field_info(document_paths) |
Member
There was a problem hiding this comment.
事后审查补充：[P1] set_document_paths 仍然接受任意值并直接保存 unwrap 结果。这个字段承担访问控制，不能只处理 FieldInfo；应该拒绝非 list[str]，并把空列表保留为“禁止所有文档”而不是 None。
影响：这个问题合入后会在对应部署、运行或权限场景中留下真实故障/安全风险，后续排查成本较高。
建议：沿着上述风险点补齐校验、配置来源、权限边界或回归测试，避免同类问题再次出现。
| Filtered list containing only results with allowed document paths | ||
| """ | ||
| allowed_paths = self._internal_document_paths | ||
| allowed_paths = _unwrap_field_info(self._internal_document_paths) |
Member
There was a problem hiding this comment.
事后审查补充：[P1] 过滤前没有把 path_or_url 和 allowed_paths 规范到同一种对象路径。s3://、/nexent/、presigned URL 三种形式会互相不匹配，访问控制结果取决于上游返回格式。
影响：这个问题合入后会在对应部署、运行或权限场景中留下真实故障/安全风险，后续排查成本较高。
建议：沿着上述风险点补齐校验、配置来源、权限边界或回归测试，避免同类问题再次出现。
| # may populate this; never the LLM. | ||
| tools_obj.set_document_paths( | ||
| tool_config.metadata.get( | ||
| "document_paths") if tool_config.metadata else None |
Member
There was a problem hiding this comment.
事后审查补充：[P1] metadata 里的 document_paths 被直接送进访问控制过滤器，没有校验来源和类型。只要 metadata 被错误构造为字符串或混合 URL，就会影响检索授权；这里应在 agent 侧先 validate/canonicalize。
影响：这个问题合入后会在对应部署、运行或权限场景中留下真实故障/安全风险，后续排查成本较高。
建议：沿着上述风险点补齐校验、配置来源、权限边界或回归测试，避免同类问题再次出现。
Dallas98
reviewed
Jun 29, 2026
Dallas98
left a comment
Dallas98
left a comment
Member
There was a problem hiding this comment.
二次事后审查补充 1/5：单条独立 review submission。
| """ | ||
| if isinstance(value, FieldInfo): | ||
| if value.default_factory is not None: | ||
| return value.default_factory() |
Member
There was a problem hiding this comment.
二次事后审查补充：[P2] default_factory 每次 unwrap 都会执行，包括过滤阶段再次调用时。如果 factory 生成的是可变列表或有副作用，允许列表会在一次请求内变化；建议在 init/set_document_paths 时解析一次并缓存具体值。
影响：该问题合入后仍可能在真实部署、运行、权限或测试场景中形成回归风险。
建议：后续按这个风险点补齐边界校验、配置来源收敛、权限约束或针对性回归测试。
Dallas98
reviewed
Jun 29, 2026
Dallas98
left a comment
Dallas98
left a comment
Member
There was a problem hiding this comment.
二次事后审查补充 2/5：单条独立 review submission。
| if value.default_factory is not None: | ||
| return value.default_factory() | ||
| return value.default | ||
| return value |
Member
There was a problem hiding this comment.
二次事后审查补充：[P1] 这里直接返回原值，没有保证 document_paths 是 list[str]。如果外部传入字符串，后续 membership 会变成对子串的检查，可能错误放行或丢弃结果；需要显式校验/转换类型。
影响：该问题合入后仍可能在真实部署、运行、权限或测试场景中形成回归风险。
建议：后续按这个风险点补齐边界校验、配置来源收敛、权限约束或针对性回归测试。
Dallas98
reviewed
Jun 29, 2026
Dallas98
left a comment
Dallas98
left a comment
Member
There was a problem hiding this comment.
二次事后审查补充 3/5：单条独立 review submission。
| document_paths: List of allowed document path_or_urls. If None, no filtering is applied. | ||
| """ | ||
| self._internal_document_paths = document_paths | ||
| self._internal_document_paths = _unwrap_field_info(document_paths) |
Member
There was a problem hiding this comment.
二次事后审查补充：[P1] set_document_paths 仍然接受任意值并直接保存 unwrap 结果。这个字段承担访问控制，不能只处理 FieldInfo；应该拒绝非 list[str]，并把空列表保留为“禁止所有文档”而不是 None。
影响：该问题合入后仍可能在真实部署、运行、权限或测试场景中形成回归风险。
建议：后续按这个风险点补齐边界校验、配置来源收敛、权限约束或针对性回归测试。
Dallas98
reviewed
Jun 29, 2026
Dallas98
left a comment
Dallas98
left a comment
Member
There was a problem hiding this comment.
二次事后审查补充 4/5：单条独立 review submission。
| Filtered list containing only results with allowed document paths | ||
| """ | ||
| allowed_paths = self._internal_document_paths | ||
| allowed_paths = _unwrap_field_info(self._internal_document_paths) |
Member
There was a problem hiding this comment.
二次事后审查补充：[P1] 过滤前没有把 path_or_url 和 allowed_paths 规范到同一种对象路径。s3://、/nexent/、presigned URL 三种形式会互相不匹配，访问控制结果取决于上游返回格式。
影响：该问题合入后仍可能在真实部署、运行、权限或测试场景中形成回归风险。
建议：后续按这个风险点补齐边界校验、配置来源收敛、权限约束或针对性回归测试。
Dallas98
reviewed
Jun 29, 2026
Dallas98
left a comment
Dallas98
left a comment
Member
There was a problem hiding this comment.
二次事后审查补充 5/5：单条独立 review submission。
| # may populate this; never the LLM. | ||
| tools_obj.set_document_paths( | ||
| tool_config.metadata.get( | ||
| "document_paths") if tool_config.metadata else None |
Member
There was a problem hiding this comment.
二次事后审查补充：[P1] metadata 里的 document_paths 被直接送进访问控制过滤器，没有校验来源和类型。只要 metadata 被错误构造为字符串或混合 URL，就会影响检索授权；这里应在 agent 侧先 validate/canonicalize。
影响：该问题合入后仍可能在真实部署、运行、权限或测试场景中形成回归风险。
建议：后续按这个风险点补齐边界校验、配置来源收敛、权限约束或针对性回归测试。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bugfix: knowledge_base_search_tool called with TypeError: argument of type 'FieldInfo' is not iterable