Revert "Release/v2.2.1"#3274
Merged
Merged
Conversation
This reverts commit 20af495.
JasonW404
reviewed
Jun 24, 2026
|
|
||
| conversation_req = MessageRequest(conversation_id=request.conversation_id, message_idx=user_role_count * 2 + 1, | ||
| role=MESSAGE_ROLE["ASSISTANT"], message=message_list, minio_files=None) | ||
| role=MESSAGE_ROLE["ASSISTANT"], message=message_list, minio_files=request.minio_files) |
Member
There was a problem hiding this comment.
此 PR 将 minio_files=None 恢复为 minio_files=request.minio_files，说明之前的修改（PR #3275）引入了 bug。建议在 commit message 或 PR description 中明确记录 revert 原因，并在未来修改同一逻辑时添加单元测试覆盖，防止再次出现回归。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3270