Skip to content

🐛 Bugfix: Fix i18n translation issues in navigation sidebar#3288

Open
xuyaqist wants to merge 16 commits into
developfrom
xyq/refactor_chat
Open

🐛 Bugfix: Fix i18n translation issues in navigation sidebar#3288
xuyaqist wants to merge 16 commits into
developfrom
xyq/refactor_chat

Conversation

@xuyaqist

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings June 23, 2026 12:29
@xuyaqist xuyaqist requested review from Dallas98 and WMC001 as code owners June 23, 2026 12:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Chinese (zh) i18n strings for several navigation sidebar items to address reported translation issues in the sidebar.

Changes:

  • Updated zh sidebar translations for Resource/Agent/MCP/Skill “Space” items to use “仓库” terminology.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1596 to +1599
"sidebar.resourceSpace": "资源仓库",
"sidebar.agentSpace": "Agent 仓库",
"sidebar.mcpSpace": "MCP 仓库",
"sidebar.skillSpace": "Skill 仓库",
@xuyaqist xuyaqist changed the title Bugfix: Fix i18n translation issues in navigation sidebar 🐛 Bugfix: Fix i18n translation issues in navigation sidebar Jun 23, 2026
@YehongPan

Copy link
Copy Markdown
Contributor

🔍 Code Review Comments

1. [代码规范] i18n key 完整性确认
应确认所有新增的 translation key 在 enzh locale 文件中都已补齐,避免 fallback 到 key 名称显示。建议添加 CI 检查自动检测缺失的 translation key。

@YehongPan YehongPan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

  • [代码规范] 应确认所有新增的 translation key 在 enzh locale 文件中都已补齐,避免 fallback 到 key 名称显示。建议添加 CI 检查自动检测缺失的 translation key。

"sidebar.agentSpace": "Agent 空间",
"sidebar.mcpSpace": "MCP 空间",
"sidebar.skillSpace": "Skill 空间",
"sidebar.resourceSpace": "资源仓库",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

将"空间"改为"仓库"是一个语义变更,不仅仅是翻译修正。"空间"(Space) 和"仓库"(Repository/Warehouse) 在用户认知上有区别——空间强调工作区域,仓库强调存储管理。请确认这个命名变更是否经过了产品/UX 团队的审核?另外需要确认英文 locale 文件中的对应翻译是否也需要同步更新。

"sidebar.mcpSpace": "MCP 空间",
"sidebar.skillSpace": "Skill 空间",
"sidebar.resourceSpace": "资源仓库",
"sidebar.agentSpace": "Agent 仓库",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

仅修改了中文 locale,但其他语言(如英文 en/common.json)中对应的 key 值是否也需要更新?如果英文仍然使用 "Space",会导致中英文 UI 语义不一致。

@WMC001

WMC001 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

LGTM. The translation additions (Korean, Japanese, Indonesian, Malay) follow the existing pattern and locale conventions. No issues found.

@WMC001 WMC001 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observation: Translation change from "空间" to "仓库"

frontend/public/locales/zh/common.json — sidebar labels changed from "X空间" to "X仓库". This is purely cosmetic. No functional impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants