Open
Conversation
qyh111
requested review from
Infinite666,
Wwwzff,
harrisonyhq,
mag1c-h and
ygwpz
as code owners
flesher0813
reviewed
Apr 3, 2026
| external_hit_tokens = 0 | ||
| if external_hit_blocks > 0: | ||
| remainder = num_computed_tokens % self.chunk_size | ||
| external_hit_tokens = external_hit_blocks * self.chunk_size - remainder |
Contributor
There was a problem hiding this comment.
Should this be external_hit_tokens = (external_hit_blocks - remainder) * self.chunk_size?
qyh111
force-pushed
the
dev_chunk_size
branch
2 times, most recently
from
63f01f5 to
660a8db
Compare
sumingZero
reviewed
Apr 7, 2026
| external_hit_tokens = 0 | ||
| if external_hit_blocks > 0: | ||
| remainder = num_computed_tokens % self.chunk_size | ||
| external_hit_tokens = external_hit_blocks * self.chunk_size - remainder |
Contributor
There was a problem hiding this comment.
Does this imply that because the initial chunk in UCM may contain blocks already present in HBM, we must deduct that overlap to accurately compute the number of external hit tokens?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Modifications
Test