[Bugfix] Fix raise with string literals in UCMBlendConnector#903
Open
SuperMarioYL wants to merge 1 commit intoModelEngine-Group:developfrom
Open
[Bugfix] Fix raise with string literals in UCMBlendConnector#903SuperMarioYL wants to merge 1 commit intoModelEngine-Group:developfrom
SuperMarioYL wants to merge 1 commit intoModelEngine-Group:developfrom
Conversation
In Python 3, `raise "string"` raises TypeError instead of the intended error message. Replace all three occurrences with proper exception types (ValueError / RuntimeError) so that callers receive meaningful error messages when: - Blend config is missing during connector initialization - setup_model() was not called before post-processing chunk cache - cos_sin_cache extraction fails for unsupported model architectures Signed-off-by: supermario_leo <leo.stack@outlook.com>
SuperMarioYL
requested review from
Infinite666,
harrisonyhq,
mag1c-h,
qyh111 and
ygwpz
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix three
raise "string"statements inUCMBlendConnectorthat produceTypeErrorat runtime instead of the intended error messages.Modifications
In Python 3,
raise "string"does not raise an exception with that message — it raises aTypeError: exceptions must derive from BaseException. This means callers never see the actual diagnostic text.raise "UCMBlendConnector init failed, ..."raise ValueError("UCMBlendConnector init failed, ...")raise "Please call setup model first."raise RuntimeError("Please call setup model first.")raise "get cos_sin_cache from model failed! ..."raise RuntimeError("get cos_sin_cache from model failed! ...")ValueErrorfor the config validation (invalid configuration input)RuntimeErrorfor the precondition and model compatibility checksTest
black --checkandisort --checkpass on the modified file.TypeErrorto the correct type with the intended message.