Skip to content

[Bugfix] Fix raise with string literals in UCMBlendConnector #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SuperMarioYL wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Bugfix] Fix raise with string literals in UCMBlendConnector #903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ucm/integration/vllm/blend_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ def __init__(self, vllm_config: "VllmConfig", role: KVConnectorRole):
self.enable_blend = True
self.chunk_end_token_id = blend_config["chunk_end_token_id"]
else:
raise "UCMBlendConnector init failed, please check your config"
raise ValueError("UCMBlendConnector init failed, please check your config")

self.requests_blend_meta: dict[str, BlendRequestMeta] = {}
self.cos_sin_cache: torch.Tensor = None
Expand Down Expand Up @@ -327,7 +327,7 @@ def _post_process_chunk_cache(self, k_cache, vllm_ids, positions) -> None:
post process loaded chunk kcache
"""
if self.cos_sin_cache is None:
raise "Please call setup model first."
raise RuntimeError("Please call setup model first.")
# triton kernl for block-wise delta rope
block_wise_rope_forward(k_cache, vllm_ids, positions, self.cos_sin_cache)

Expand All @@ -336,7 +336,9 @@ def _register_cos_sin_cache(self, model: "Model") -> None:
rotary_emb = model.model.layers[0].self_attn.rotary_emb
self.cos_sin_cache = rotary_emb.cos_sin_cache
except Exception:
raise "get cos_sin_cache from model failed! current not implemented for this model"
raise RuntimeError(
"get cos_sin_cache from model failed! current not implemented for this model"
)

def setup_model(self, model: "Model") -> None:
self._register_cos_sin_cache(model)
Expand Down
Loading