[BugFix] Add patch for local_cache_hit calculation in vllm 0.18.0 met…#941
Merged
qyh111 merged 1 commit intoModelEngine-Group:developfrom Apr 29, 2026
Merged
Conversation
qyh111
approved these changes
Apr 29, 2026
qyh111
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix negative
local_cache_hitcalculation that can crash Prometheus counters.Related vLLM issue: vllm-project/vllm#36755
When preemption occurs with async scheduling, there's a race condition where:
schedule(N+1)can preempt a request and reset its stateupdate_from_output(N)reads the already-mutated request stateThis can result in
num_external_computed_tokensexceedingnum_cached_tokens + recomputed, causinglocal_cache_hitto become negative. Prometheus counters then crash with:ValueError: Counters can only be incremented by non-negative amounts.
Modifications
vllm.v1.metrics.stats.PromptTokenStats.update_from_outputto wraplocal_cache_hitcalculation withmax(0, ...)v0180/vllm/pc/metrics/stats.pywith the patched methodv0180/vllm/pc_patch.pyto register the patchapply_patch.pyto support vllm 0.18.0 version