fix: address review feedback for logging refactor

- Fix typo 'recive' -> 'receive' in router manager
- Uppercase 'mtp' -> 'MTP' in status line for consistency
- Only show MTP metric when MTP is actually active
- Remove dead code: log_time_ready and unused time import
- Add file handler to status logger when LIGHTLLM_LOG_DIR is set
- Warn when log_stats_interval is below 5s minimum

Author: sufubao

lightllm/server/router/manager.py

@@ -426,7 +426,7 @@ def _add_req(self, group_req_indexes: GroupReqIndexes):
             req._router_stop_str_matched = False
             req_group.append(req)
 
-            logger.debug(f"router recive req id {req.request_id} cost time {time.time() - req.start_time} s")
+            logger.debug(f"router receive req id {req.request_id} cost time {time.time() - req.start_time} s")
         self.req_queue.extend(req_group)
         self.send_to_detokenization.send_pyobj(group_req_indexes, protocol=pickle.HIGHEST_PROTOCOL)
         return

lightllm/server/router/stats.py

@@ -3,15 +3,15 @@
 from lightllm.server.core.objs import StartArgs
 from lightllm.utils.log_utils import init_system_status_logger
 
+logger = logging.getLogger(__name__)
+
 
 class SystemStatusReporter:
     def __init__(self, args, max_total_token_num, dp_size_in_node):
         self.enabled = not args.disable_log_stats
         self.interval = max(5, args.log_stats_interval)
         if args.log_stats_interval < 5:
-            logging.getLogger(__name__).warning(
-                f"log_stats_interval={args.log_stats_interval}s is below minimum, using 5s"
-            )
+            logger.warning(f"log_stats_interval={args.log_stats_interval}s is below minimum, using 5s")
         self.max_total_token_num = max_total_token_num
         self.dp_size_in_node = dp_size_in_node
         self.status_logger = init_system_status_logger("router")

lightllm/utils/log_utils.py

@@ -4,7 +4,6 @@
 import logging
 import sys
 import os
-import time
 from typing import Optional
 
 _FORMAT = "%(levelname)s %(asctime)s [%(filename)s:%(lineno)d] %(message)s"
@@ -102,31 +101,15 @@ def init_system_status_logger(name: str):
     logger = logging.getLogger(f"lightllm.status.{name}")
     if not logger.handlers:
         logger.setLevel(logging.INFO)
+        fmt = logging.Formatter(_STATUS_FORMAT, datefmt=_DATE_FORMAT)
         handler = logging.StreamHandler(sys.stdout)
         handler.flush = sys.stdout.flush
-        fmt = logging.Formatter(_STATUS_FORMAT, datefmt=_DATE_FORMAT)
         handler.setFormatter(fmt)
         logger.addHandler(handler)
+        if _LOG_DIR is not None:
+            file_handler = logging.FileHandler(os.path.join(_LOG_DIR, f"status.{name}.log"))
+            file_handler.setLevel(logging.INFO)
+            file_handler.setFormatter(fmt)
+            logger.addHandler(file_handler)
         logger.propagate = False
     return logger
-
-
-_log_time_mark_dict = {}
-
-
-def log_time_ready(mark_name, time_count: int):
-    """
-    time_count 间隔时间超过多少s调用该函数会返回True，否则返回False
-    用于控制一些日志输出的频率
-    """
-    global _log_time_mark_dict
-
-    if mark_name not in _log_time_mark_dict:
-        _log_time_mark_dict[mark_name] = time.time()
-        return False
-    cur_time_mark = time.time()
-    if cur_time_mark - _log_time_mark_dict[mark_name] >= time_count:
-        _log_time_mark_dict[mark_name] = cur_time_mark
-        return True
-    else:
-        return False