Deb/flux2 dmd2#1205
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces training configurations and model updates for Flux2 Klein using DMD and LoRA. Key changes include adding a new YAML configuration file, updating load_components in Flux2KleinModel to support transformer-only loading, and implementing latent shape and conditioning helper methods. Feedback is provided regarding a potential duplicate definition of dmd_latent_shape in the base model class.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| def dmd_latent_shape(self, batch_size, height, width): | ||
| raise NotImplementedError(f"{self.__class__.__name__} must define dmd_latent_shape().") |
There was a problem hiding this comment.
The method dmd_latent_shape is already defined at lines 169-170 in this file. Adding it here at lines 30-31 introduces a duplicate method definition. Please remove this duplicate definition to keep the class clean and maintainable.
1 participant
No description provided.