Skip to content

[222_63] Remove unnecessary floating text toolbar label when selecting the text#3020

Closed
Prthmsh7 wants to merge 1 commit intoMoganLab:mainfrom
Prthmsh7:222_63
Closed

[222_63] Remove unnecessary floating text toolbar label when selecting the text#3020
Prthmsh7 wants to merge 1 commit intoMoganLab:mainfrom
Prthmsh7:222_63

Conversation

@Prthmsh7
Copy link
Copy Markdown
Contributor

Fixes #3019

What

Removed the hardcoded "文本工具栏" (Text Toolbar) label from the floating text toolbar.

Before:
Screenshot 2026-03-20 at 3 09 55 PM

After:
Screenshot 2026-03-20 at 3 19 26 PM

Fix

  1. Removed the QLabel creation in QTMTextToolbar::rebuildButtonsFromScheme()
  2. Removed unused #include

@Prthmsh7
Copy link
Copy Markdown
Contributor Author

@Yuki-Nagori please review when free. Thanks!

@Yuki-Nagori
Copy link
Copy Markdown
Contributor

Yuki-Nagori commented Apr 9, 2026

@Prthmsh7 Sorry for the late reply, I've been quite busy recently. This is the placeholder for the Text Toolbar that needed to be implemented earlier — it's a PR split from an already implemented draft. That functionality is now controlled within xmake.lua. Thank you for your PR, I'm closing this one.

@Yuki-Nagori Yuki-Nagori closed this Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary floating label appears when selecting text

2 participants