[1129] 引入 goldfish package,移除 s7 package#3849
Open
da-liii wants to merge 2 commits into
Open
Conversation
记录把 s7 package 迁移为 goldfish package 的背景、方案与验证。 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
在 xmake/goldfish.lua 新增 package("goldfish") 定义,源码来自
TeXmacs/plugins/goldfish/src/,on_install 在包缓存目录内联生成
libgoldfish 静态库 target 并公开 s7.h。libmogan/stem/tests 改用
add_packages("goldfish"),删除 xmake/packages/s/s7/。
goldfish binary target 保持不变。
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xmake/goldfish.lua新增package("goldfish")定义,源码来自TeXmacs/plugins/goldfish/src/,on_install在包缓存目录内联生成libgoldfish静态库 target(编译全部s7*.c,C11)并公开s7.h。libmogan/stem/ tests 的add_packages("s7")全部改为add_packages("goldfish");xmake.lua的add_requires("s7")改为add_requires("goldfish")。xmake/packages/s/s7/(含xmake.lua与port/xmake.lua)。xmake/goldfish.lua中的 goldfish binary target(含goldfish.cpp的 REPL 可执行文件)保持不变。Why
s7 package 与 goldfish binary target 此前各自维护一份完全相同的 19 个 s7 源文件清单,容易漂移。s7 只是 goldfish 的内置 Scheme 引擎,对外单元应当是 goldfish。改为 goldfish package 后,源码出处唯一,命名也与项目身份对齐。
详见
devel/1129.md。Test plan
grep -rn 'add_requires.*"s7"\|add_packages.*"s7"' xmake.lua xmake/*.lua无匹配xmake f -c --yes配置通过,goldfish package 成功安装xmake b stem构建通过(libmogan.a / moganstem 链接成功)🤖 Generated with Claude Code