[core][view] Add offset or contiguous guards for all get and set methods#319
Merged
Conversation
forfudan
added this to the
[Milestone] View Safety: Fix Contiguity Assumptions Across the Codebase milestone
shivasankarka
approved these changes
Feb 23, 2026
forfudan
added a commit
that referenced
this pull request
Mar 31, 2026
…methods (#319) This PR is related to Issue #309 (Phase 4) for view safety. It brings offset-aware core getters/setters. Problem is that aroudn 30 locations in ndarray.mojo, we accessed `self._buf.ptr[i]` directly without adding `self.offset`, causing data corruption on views that share a buffer with non-zero offset. Fixes are applied to core get dunders, set dunders, store method, load method, etc. Add new tests covering load/store, item/itemset, __getitem__/__setitem__ with Item/Int/mask/slices on offset views. All tests pass across the full suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to Issue #309 (Phase 4) for view safety. It brings offset-aware core getters/setters.
Problem is that aroudn 30 locations in ndarray.mojo, we accessed
self._buf.ptr[i]directly without addingself.offset, causing data corruption on views that share a buffer with non-zero offset.Fixes are applied to core get dunders, set dunders, store method, load method, etc.
Add new tests covering load/store, item/itemset, getitem/setitem with Item/Int/mask/slices on offset views. All tests pass across the full suite.