[NDArray] unify the __getitem__ slice overloads#353
Merged
forfudan merged 3 commits intoMay 7, 2026
Merged
Conversation
shivasankarka
changed the title
__getitem__ slice overloads
forfudan
merged commit May 7, 2026
bd1a8f7
into
Mojo-Numerics-and-Algorithms-group:pre-0.10
2 checks passed
shivasankarka
added a commit
to shivasankarka/NuMojo
that referenced
this pull request
May 8, 2026
…Algorithms-group#353) - `__getitem__(*slices: Slice)` wraps each `Slice` into `IndexTypes` and calls `__getitem__(*slices: IndexTypes)`. - `__getitem__(slice_list: List[Slice])` similarly wraps and delegates. - `__getitem__(*slices: IndexTypes)` is the single implementation. - `_getitem_list_slices` (internal helper with dimension-reducing semantics for computation compatibility) is kept as-is since it has different behavior. - Fix the issue in ellipsis expansion when there are other indices provided such as `arr[..., -1]`. - Fix pixi-backend mojo version.
shivasankarka
added a commit
to shivasankarka/NuMojo
that referenced
this pull request
May 8, 2026
…Algorithms-group#353) - `__getitem__(*slices: Slice)` wraps each `Slice` into `IndexTypes` and calls `__getitem__(*slices: IndexTypes)`. - `__getitem__(slice_list: List[Slice])` similarly wraps and delegates. - `__getitem__(*slices: IndexTypes)` is the single implementation. - `_getitem_list_slices` (internal helper with dimension-reducing semantics for computation compatibility) is kept as-is since it has different behavior. - Fix the issue in ellipsis expansion when there are other indices provided such as `arr[..., -1]`. - Fix pixi-backend mojo version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
__getitem__(*slices: Slice)wraps eachSliceintoIndexTypesand calls__getitem__(*slices: IndexTypes).__getitem__(slice_list: List[Slice])similarly wraps and delegates.__getitem__(*slices: IndexTypes)is the single implementation._getitem_list_slices(internal helper with dimension-reducing semantics for computation compatibility) is kept as-is since it has different behavior.arr[..., -1].