Prevent crash on failed GRP evaluation#49
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prevents crashes in GEMCAT when GPR (Gene-Protein-Reaction) expression parsing fails by gracefully handling syntax errors and returning NaN instead of allowing the application to crash.
- Adds exception handling around GPR expression parsing to catch SyntaxError exceptions
- Returns NaN when parsing fails, allowing execution to continue
- Includes debug logging to track failed parsing attempts
- Bumps version from 1.4.0 to 1.4.1
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/gemcat/expression.py | Adds try-catch block around parse_expr to handle SyntaxError and return NaN on failure |
| pyproject.toml | Version bump from 1.4.0 to 1.4.1 |
surajsept
approved these changes
Jul 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a failed GPR evaluation can crash the whole GEMCAT run.
Returning NaN for the crashing GPR and continuing execution is preferable.