chore: autorouter migrate to v6 by PeeyushDas · Pull Request #72 · Monday-Morning/project-pegasus

PeeyushDas · 2023-09-08T12:02:20Z

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
Check the commit's or even all commits' message styles matches our requested structure.
Check your code additions will fail neither code linting checks nor unit test.
I have added necessary documentation (if appropriate)

Linked Issues

Fixes

Description

Please describe your pull request.

❤️Thank you!

Post merge checklist

Follow steps from the guidelines for contributing to this repository.
If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

…branch1

PeeyushDas · 2023-09-08T12:05:22Z

@120EE0692

rutajdash

Are we migrating to Material 3? If yes, why? If not, why was the design system changed?
Why is the coming soon page renamed to the expression page?

rutajdash · 2023-09-20T16:41:54Z

 		signingConfigs {
 				release {
-						storeFile file(keystoreProperties['storeFile'])
+						storeFile file("key.jks")


Why was this change committed?

@rutajdash
Sir, when i try to run the app with
storeFile file(keystoreProperties['storeFile'])

The following error pops up in the terminal

Launching lib/main.dart on SM E225F in debug mode...

FAILURE: Build failed with an exception.

Where:
Build file '/home/peeyushdas/Desktop/MONDAY MORNING 2023/project-pegasus/app/android/app/build.gradle' line: 85

What went wrong:
A problem occurred evaluating project ':app'.

path may not be null or empty string. path='null'

And then I searched for the issue on stackoverflow, and I got this solution:-

link:- https://stackoverflow.com/questions/54457245/a-problem-occurred-evaluating-project-app-path-may-not-be-null-or-empty-st

Yes, we use a keystore properties file for production builds along with other credential files, which for obvious reasons is not shared to all developers.
For development, making this change is acceptable but it should not be committed but only kept on your local system.

rutajdash · 2023-09-20T16:42:06Z

 dependencies {
    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
-    implementation 'com.google.android.material:material:1.7.0'
+    implementation 'com.google.android.material:material:1.6.1'


Why the downgrade?

rutajdash · 2023-09-20T16:42:35Z


    dependencies {
-        classpath 'com.android.tools.build:gradle:7.1.2'
+        classpath 'com.android.tools.build:gradle:7.0.4'


Why the downgrade?

rutajdash · 2023-09-20T16:44:35Z

-import 'package:mondaymorning/src/services/router/mm_router.dart';
 import 'package:mondaymorning/src/services/themes/index.dart';
 import 'package:mondaymorning/src/store/states/app_config/app_config_provider.dart';
+import 'services/router/mm_router.dart';


Suggested change

import 'services/router/mm_router.dart';

import 'package:mondaymorning/src/services/router/mm_router.dart';

Avoid using relative imports.

rutajdash · 2023-09-20T16:46:07Z

 import 'package:mondaymorning/src/ui/screens/full_error_screen.dart';
-import 'package:mondaymorning/src/ui/screens/full_loading_screen.dart';

+@RoutePage<dynamic>(name: 'ArticleRoute')


Why dynamic? This page doesn't return any data so it should be void instead.

Suggested change

@RoutePage<dynamic>(name: 'ArticleRoute')

@RoutePage<void>(name: 'ArticleRoute')

rutajdash · 2023-09-20T16:55:43Z

 import 'package:mondaymorning/src/ui/components/article/article_carousel.dart';
 import 'package:mondaymorning/src/ui/components/category/sub_category_section.dart';

+@RoutePage<dynamic>(name: 'AllCategoryRoute')


Suggested change

@RoutePage<dynamic>(name: 'AllCategoryRoute')

@RoutePage<void>(name: 'AllCategoryRoute')

rutajdash · 2023-09-20T16:56:44Z

 import 'package:mondaymorning/src/ui/components/home/search_app_bar.dart';
-import 'package:mondaymorning/src/services/router/mm_router.dart';

+@RoutePage<dynamic>(name: 'HomeRoute')


Suggested change

@RoutePage<dynamic>(name: 'HomeRoute')

@RoutePage<void>(name: 'HomeRoute')

rutajdash · 2023-09-20T16:57:02Z

 }

 /// More Screen of the app.
+@RoutePage<dynamic>(name: 'MoreRoute')


Suggested change

@RoutePage<dynamic>(name: 'MoreRoute')

@RoutePage<void>(name: 'MoreRoute')

rutajdash · 2023-09-20T16:57:25Z

 import 'package:mondaymorning/src/ui/components/article/article_carousel.dart';
 import 'package:mondaymorning/src/ui/components/article/small_article_card.dart';

+@RoutePage<dynamic>(name: 'SubCategoryRoute')


Suggested change

@RoutePage<dynamic>(name: 'SubCategoryRoute')

@RoutePage<void>(name: 'SubCategoryRoute')

rutajdash · 2023-09-20T16:57:39Z

 import 'package:mondaymorning/src/ui/components/terms/terms_content.dart';
-import 'package:mondaymorning/src/services/router/mm_router.dart';

+@RoutePage<dynamic>(name: 'TermsRoute')


Suggested change

@RoutePage<dynamic>(name: 'TermsRoute')

@RoutePage<void>(name: 'TermsRoute')

sambit-sankalp · 2023-09-25T14:04:27Z

We need to make another PR as there is a change in the visibility of the repository.
Link to other PR - #74

We can close this PR and start reviewing the other.

Peeyush Das added 6 commits August 22, 2023 22:44

update CC's contacts

4a5364e

build: Autorouter migrated to V6

aa550c6

Merge branch 'main' of github.com:PeeyushDas/project-pegasus

a68bab7

fix: Autorouter to v6

d944a7d

chore:autorouter migrate to v6

5904b9f

Merge branch 'branch1' of github.com:PeeyushDas/project-pegasus into …

68303b9

…branch1

PeeyushDas changed the title ~~chore: Autorouter migrate to v6~~ chore: autorouter migrate to v6 Sep 8, 2023

120EE0692 requested a review from rutajdash September 20, 2023 05:10

120EE0692 assigned PeeyushDas Sep 20, 2023

rutajdash requested changes Sep 20, 2023

View reviewed changes

sambit-sankalp closed this Oct 14, 2023

	import 'services/router/mm_router.dart';
	import 'package:mondaymorning/src/services/router/mm_router.dart';

	@RoutePage<dynamic>(name: 'ArticleRoute')
	@RoutePage<void>(name: 'ArticleRoute')

	@RoutePage<dynamic>(name: 'AllCategoryRoute')
	@RoutePage<void>(name: 'AllCategoryRoute')

	@RoutePage<dynamic>(name: 'HomeRoute')
	@RoutePage<void>(name: 'HomeRoute')

	@RoutePage<dynamic>(name: 'MoreRoute')
	@RoutePage<void>(name: 'MoreRoute')

	@RoutePage<dynamic>(name: 'SubCategoryRoute')
	@RoutePage<void>(name: 'SubCategoryRoute')

	@RoutePage<dynamic>(name: 'TermsRoute')
	@RoutePage<void>(name: 'TermsRoute')

Conversation

PeeyushDas commented Sep 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Your checklist for this pull request

Linked Issues

Description

Post merge checklist

Uh oh!

PeeyushDas commented Sep 8, 2023

Uh oh!

rutajdash left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rutajdash Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sambit-sankalp commented Sep 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PeeyushDas commented Sep 8, 2023 •

edited

Loading

rutajdash Sep 20, 2023 •

edited

Loading

sambit-sankalp commented Sep 25, 2023 •

edited

Loading