Accept XTM SubmitBlock hash responses

Tari SubmitBlock reports successful XTM submissions with result.block_hash and no status OK field. The generic object-result acceptor treated those accepted blocks as unknown RPC results, retried them, and sent false block-submit failure emails on sg/de nodes.

Author: MoneroOcean

lib/coins/core/factories.js

@@ -1144,6 +1144,15 @@ function acceptStatusOkObject(ctx) {
     return !!(ctx.rpcResult && typeof ctx.rpcResult.result === "object" && ctx.rpcResult.result && ctx.rpcResult.result.status === "OK");
 }
 
+// Tari SubmitBlock returns result.block_hash without status OK on success.
+// Treating it as generic object result makes valid XTM blocks retry and alert.
+function acceptXtmBlockHashResult(ctx) {
+    if (!ctx.rpcResult || typeof ctx.rpcResult.result !== "object" || !ctx.rpcResult.result) return false;
+    const blockHash = ctx.rpcResult.result.block_hash;
+    if (Array.isArray(blockHash) || Buffer.isBuffer(blockHash)) return blockHash.length > 0;
+    return typeof blockHash === "string" && blockHash.length > 0;
+}
+
 function acceptNonRejectedResponse(ctx) { return !!(ctx.rpcResult && ctx.rpcResult.response !== "rejected"); }
 
 function acceptAccepted202String(ctx) { return typeof ctx.rpcResult === "string" && ctx.rpcStatus == 202; }
@@ -1176,7 +1185,10 @@ function resolveEthSubmittedBlockHash(ctx, callback) {
 }
 
 function resolveXtmSubmittedBlockHash(ctx, callback) {
-    return callback(Buffer.from(ctx.rpcResult.result.block_hash).toString("hex"));
+    const blockHash = ctx.rpcResult && ctx.rpcResult.result && ctx.rpcResult.result.block_hash;
+    if (Array.isArray(blockHash) || Buffer.isBuffer(blockHash)) return callback(Buffer.from(blockHash).toString("hex"));
+    if (typeof blockHash === "string") return callback(blockHash);
+    return callback("0".repeat(64));
 }
 
 function submitCryptonoteBlock(ctx) {
@@ -1344,6 +1356,7 @@ const pool = {
             submitSuccess: "boolean",
             sendLoginResult: sendXtmCLoginResult,
             verifySpecialShare: verifyXtmCShare,
+            acceptSubmittedBlock: acceptXtmBlockHashResult,
             resolveSubmittedBlockHash: resolveXtmSubmittedBlockHash,
             submitBlockRpc: submitXtmCBlock,
             jobAlgo: "cuckaroo",
@@ -1353,6 +1366,7 @@ const pool = {
 };
 pool.submitAccept = Object.freeze({
     statusOkObject: acceptStatusOkObject,
+    xtmBlockHashResult: acceptXtmBlockHashResult,
     accepted202String: acceptAccepted202String
 });
 pool.blockHash = Object.freeze({

lib/coins/xtm_t.js

@@ -4,6 +4,7 @@ const { blob, pool, pow, preset, rpc } = require("./core/factories.js");
 module.exports = preset.directReserve({ port: 18146, coin: "XTM-T", blobType: 106, algo: "rx/0", blobTypeName: "xtm-t",
     blob: blob.xtmT(),
     pool: pool.standard({
+        acceptSubmittedBlock: pool.submitAccept.xtmBlockHashResult,
         resolveSubmittedBlockHash: pool.blockHash.xtmRpcHash,
         submitBlockRpc: pool.blockSubmit.xtmRx
     }),

tests/pool/coin/submitters.js

@@ -514,6 +514,13 @@ test("xtm submit and verify handlers preserve the pre-refactor special-case tari
         }
     });
 
+    assert.equal(xtmTPool.acceptSubmittedBlock({ rpcResult: { result: { block_hash: [0, 1, 2, 255] } } }), true);
+    assert.equal(xtmTPool.acceptSubmittedBlock({ rpcResult: { result: { block_hash: "11".repeat(32) } } }), true);
+    assert.equal(xtmTPool.acceptSubmittedBlock({ rpcResult: { result: { status: "OK" } } }), false);
+    assert.equal(xtmTPool.acceptSubmittedBlock({ rpcResult: { result: { status: "FAILED" } } }), false);
+    assert.equal(xtmCPool.acceptSubmittedBlock({ rpcResult: { result: { block_hash: [1, 2, 3] } } }), true);
+    assert.equal(xtmCPool.acceptSubmittedBlock({ rpcResult: { result: { status: "OK" } } }), false);
+
     assert.equal(resolvedRxHash, "000102ff");
     assert.equal(xtmRxCalls.length, 1);
     assert.equal(xtmRxCalls[0].port, 18146);