Skip to content

Commit f52308d

Browse files
committed
Extend JDBC_API_Tester to allow passing of extra arg: -supportsNestedTypes
This is needed to adapt the expected output for Test_PSmetadata(). On the MonetDB nested branch a prepared statement now returns different metadata for schemaname and nullable properties of result columns.
1 parent 60af43e commit f52308d

1 file changed

Lines changed: 16 additions & 13 deletions

File tree

tests/JDBC_API_Tester.java

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@ public final class JDBC_API_Tester {
7373

7474
/**
7575
* main function
76-
* @param args args[0] should contain the connectionURL string, args[1] an optional flag: -skipMALoutput
76+
* @param args args[0] should contain the connectionURL string,
77+
* args[1] an optional flag: -skipMALoutput or -supportsNestedTypes
7778
* @throws Exception if a connection or database access error occurs
7879
*/
7980
public static void main(String[] args) throws Exception {
@@ -85,6 +86,8 @@ public static void main(String[] args) throws Exception {
8586
final String con_URL = args[0];
8687
final boolean skipMALoutput = (args.length >= 2) ? args[1].equals("-skipMALoutput") : false;
8788
// System.err.println("skipMALoutput = " + skipMALoutput);
89+
final boolean supportsNestedTypes = (args.length >= 2) ? args[1].equals("-supportsNestedTypes") : false;
90+
// System.err.println("supportsNestedTypes = " + supportsNestedTypes);
8891

8992
// Test this before trying to connect
9093
UrlTester.runAllTests();
@@ -113,7 +116,7 @@ public static void main(String[] args) throws Exception {
113116
jt.Test_PSlargebatchval();
114117
jt.Test_PSlargeresponse(con_URL);
115118
jt.Test_PSmanycon(con_URL);
116-
jt.Test_PSmetadata();
119+
jt.Test_PSmetadata(supportsNestedTypes);
117120
jt.Test_PSsetBytes();
118121
jt.Test_PSsomeamount();
119122
jt.Test_PSsqldata();
@@ -2552,7 +2555,7 @@ private void Test_PSmanycon(String arg0) {
25522555
"56... result: 56, closed. 57... result: 57, closed. 58... result: 58, closed. 59... result: 59, closed. 60... result: 60, closed. Forced transaction failure\n");
25532556
}
25542557

2555-
private void Test_PSmetadata() {
2558+
private void Test_PSmetadata(boolean supportsNestedTypes) {
25562559
sb.setLength(0); // clear the output log buffer
25572560

25582561
Statement stmt = null;
@@ -2660,13 +2663,13 @@ private void Test_PSmetadata() {
26602663
" precision 10\n" +
26612664
" scale 0\n" +
26622665
" catalogname null\n" +
2663-
" schemaname \n" +
2666+
" schemaname " + (supportsNestedTypes ? "sys\n" : "\n") +
26642667
" tablename table_test_psmetadata\n" +
26652668
" autoincrement false\n" +
26662669
" casesensitive false\n" +
26672670
" currency false\n" +
26682671
" defwritable false\n" +
2669-
" nullable 2\n" +
2672+
" nullable " + (supportsNestedTypes ? "1\n" : "2\n") +
26702673
" readonly true\n" +
26712674
" searchable true\n" +
26722675
" signed true\n" +
@@ -2681,13 +2684,13 @@ private void Test_PSmetadata() {
26812684
" precision 15\n" +
26822685
" scale 0\n" +
26832686
" catalogname null\n" +
2684-
" schemaname \n" +
2687+
" schemaname " + (supportsNestedTypes ? "sys\n" : "\n") +
26852688
" tablename table_test_psmetadata\n" +
26862689
" autoincrement false\n" +
26872690
" casesensitive false\n" +
26882691
" currency false\n" +
26892692
" defwritable false\n" +
2690-
" nullable 2\n" +
2693+
" nullable " + (supportsNestedTypes ? "1\n" : "2\n") +
26912694
" readonly true\n" +
26922695
" searchable true\n" +
26932696
" signed true\n" +
@@ -2702,13 +2705,13 @@ private void Test_PSmetadata() {
27022705
" precision 1\n" +
27032706
" scale 0\n" +
27042707
" catalogname null\n" +
2705-
" schemaname \n" +
2708+
" schemaname " + (supportsNestedTypes ? "sys\n" : "\n") +
27062709
" tablename table_test_psmetadata\n" +
27072710
" autoincrement false\n" +
27082711
" casesensitive false\n" +
27092712
" currency false\n" +
27102713
" defwritable false\n" +
2711-
" nullable 2\n" +
2714+
" nullable " + (supportsNestedTypes ? "1\n" : "2\n") +
27122715
" readonly true\n" +
27132716
" searchable true\n" +
27142717
" signed false\n" +
@@ -2723,13 +2726,13 @@ private void Test_PSmetadata() {
27232726
" precision 15\n" +
27242727
" scale 0\n" +
27252728
" catalogname null\n" +
2726-
" schemaname \n" +
2729+
" schemaname " + (supportsNestedTypes ? "sys\n" : "\n") +
27272730
" tablename table_test_psmetadata\n" +
27282731
" autoincrement false\n" +
27292732
" casesensitive true\n" +
27302733
" currency false\n" +
27312734
" defwritable false\n" +
2732-
" nullable 2\n" +
2735+
" nullable " + (supportsNestedTypes ? "1\n" : "2\n") +
27332736
" readonly true\n" +
27342737
" searchable true\n" +
27352738
" signed false\n" +
@@ -2744,13 +2747,13 @@ private void Test_PSmetadata() {
27442747
" precision 0\n" +
27452748
" scale 0\n" +
27462749
" catalogname null\n" +
2747-
" schemaname \n" +
2750+
" schemaname " + (supportsNestedTypes ? "sys\n" : "\n") +
27482751
" tablename table_test_psmetadata\n" +
27492752
" autoincrement false\n" +
27502753
" casesensitive true\n" +
27512754
" currency false\n" +
27522755
" defwritable false\n" +
2753-
" nullable 2\n" +
2756+
" nullable " + (supportsNestedTypes ? "1\n" : "2\n") +
27542757
" readonly true\n" +
27552758
" searchable true\n" +
27562759
" signed false\n" +

0 commit comments

Comments
 (0)