Skip to content

highlighting fix in building_2d_games/Chapter 11#126

Closed
Omar-Gebal wants to merge 3 commits intoMonoGame:mainfrom
Omar-Gebal:main
Closed

highlighting fix in building_2d_games/Chapter 11#126
Omar-Gebal wants to merge 3 commits intoMonoGame:mainfrom
Omar-Gebal:main

Conversation

@Omar-Gebal
Copy link
Copy Markdown
Contributor

Here it indicates that using MonoGameLibrary.Graphics; is the new line while using MonoGameLibrary.Input; is the actual new line, it is kinda silly I know but thought why not fix it

@Omar-Gebal
Copy link
Copy Markdown
Contributor Author

Ok I have noticed all the highlighting in the file is one line off so I am going to fix that now too

The highlighting was 1 line off in one snippet
@Omar-Gebal
Copy link
Copy Markdown
Contributor Author

I just noticed that in the Updating Game1 Class section there is a change not applied.
Where it says:
image

but it still uses the old method as shown here
image

I think this requires to call ExitOnEscape = true; in the Initialize() method in the Game1 class. and removing it from the Update method (Which I tested and it works), I noticed that this is not corrected in the chapters ahead though, I can open a new pull request and put in the effort to fix it if you give me the greenlight

@SimonDarksideJ
Copy link
Copy Markdown
Collaborator

Thanks but looks like these changes were already picked up

@Omar-Gebal
Copy link
Copy Markdown
Contributor Author

@SimonDarksideJ yeah apparently someone commited them a week after me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants