Tutorial - Building 2D Games - Fix circle collision math and a few typos.#138
Merged
SimonDarksideJ merged 6 commits intoMonoGame:mainfrom Jun 12, 2025
Merged
Tutorial - Building 2D Games - Fix circle collision math and a few typos.#138SimonDarksideJ merged 6 commits intoMonoGame:mainfrom
SimonDarksideJ merged 6 commits intoMonoGame:mainfrom
Conversation
The circle collision explanation and code sample were incorrect. The Circle class is implemented correctly later in this chapter (see ./snippets/cirlce.cs#methods_intersects).
AristurtleDev
suggested changes
Jun 9, 2025
Contributor
AristurtleDev
left a comment
AristurtleDev
left a comment
There was a problem hiding this comment.
Thanks for catching the maths errors.
A few minor feedback points were added to the review if you could look over them.
articles/tutorials/building_2d_games/12_collision_detection/index.md
Outdated
Show resolved
Hide resolved
articles/tutorials/building_2d_games/12_collision_detection/index.md
Outdated
Show resolved
Hide resolved
articles/tutorials/building_2d_games/12_collision_detection/snippets/vector2_distance.cs
Outdated
Show resolved
Hide resolved
dellis1972
requested review from
AristurtleDev and
SimonDarksideJ
and removed request for
AristurtleDev
Gaetz
pushed a commit
to Gaetz/docs.monogame.github.io
that referenced
this pull request
Jul 16, 2025
…pos. (MonoGame#138) * Fix circle collision math and a few typos. The circle collision explanation and code sample were incorrect. The Circle class is implemented correctly later in this chapter (see ./snippets/cirlce.cs#methods_intersects). * Add back "Since this forms a right triangle," * Use * instead of _ * Switch circle radii back to 5 * Corrections --------- Co-authored-by: Simon (Darkside) Jackson <darkside@zenithmoon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Building 2D Games tutorial is amazing! I really appreciate the hard work that went into it. I went through Chapter 12 and everything was great until the circle collision explanation. There's a couple of errors pertaining to the direction of inequality sign, so this MR attempts to straighten it out. It's notable that the
Circleclass is implemented correctly later in this chapter (see./snippets/cirlce.cs#methods_intersects).