Skip to content

Commit 1fce766

Browse files
committed
strengthen that at one firmware build is necessary after code changes.
1 parent 19b44b7 commit 1fce766

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

.github/agent-build-instructions.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ Use these timeout values when running builds:
3838
3. Then build and test firmware
3939

4040

41-
## Before Finishing Work
41+
## Before Finishing Work - Testing
4242

4343
**You MUST complete ALL of these before marking work as done:**
4444

4545
1. **Run tests**: `npm test` — must pass
46-
2. **Build firmware**: `pio run -e esp32_4MB_V4_M` — must succeed
46+
2. **Build firmware**: `pio run -e esp32_4MB_V4_M` — must succeed after source code changes, **never skip this step**.
4747
- Set timeout to 30+ minutes, **never cancel**
4848
- Choose `esp32_4MB_V4_M` as a common, representative environment
4949
- If the build fails, fix the issue before proceeding

.github/copilot-instructions.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ Always reference these instructions first and fallback to search or bash command
2828
| ESP32-P4/-C5/-C6 | Will be supported in the future |
2929
| ESP8266 | Deprecated — should still compile, but not actively maintained |
3030

31-
<!-- HUMAN_ONLY_START -->
3231
## Build and Test
32+
<!-- HUMAN_ONLY_START -->
3333

3434
| Command | Purpose | Typical Time |
3535
|---|---|---|
@@ -38,13 +38,14 @@ Always reference these instructions first and fallback to search or bash command
3838
| `npm run dev` | Watch mode — auto-rebuilds web UI on file changes ||
3939
| `pio run -e <env>` | Build firmware for a hardware target | 15–20 min |
4040

41-
**Always run `npm ci; npm run build` before `pio run`.** The web UI build generates `wled00/html_*.h` header files required by firmware compilation.
41+
<!-- HUMAN_ONLY_END -->
4242

43+
**Always run `npm ci; npm run build` before `pio run`.** The web UI build generates `wled00/html_*.h` header files required by firmware compilation.
44+
**Build firmware to validate code changes**: `pio run -e esp32_4MB_V4_M` — must succeed, never skip this step.
4345
Common firmware environments: `esp32_4MB_V4_M`, `esp32_16MB_V4_S_HUB75`, `esp32S3_8MB_PSRAM_M_qspi`, `esp32_16MB_V4_M_eth`, `esp32dev_compat`, `esp8266_4MB_S` (deprecated)
4446

4547
For detailed build timeouts, development workflows, troubleshooting, and validation steps, see [agent-build-instructions.md](agent-build-instructions.md).
4648

47-
<!-- HUMAN_ONLY_END -->
4849
## Repository Structure
4950

5051
tl;dr:

0 commit comments

Comments
 (0)