hotfix: inplace pin memory caused cudaErrorHostMemoryAlreadyRegistered#69
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a CUDA error (cudaErrorHostMemoryAlreadyRegistered) that occurred when reusing inplace pin memory by implementing manual memory unpinning with cudaHostUnregister. The changes also make inplace pin memory the default behavior and add NPU device compatibility checks.
Key Changes:
- Implemented manual memory unpinning using
cudaHostUnregisterfor CUDA-registered memory to prevent reuse errors - Changed default value of
use_inplace_pin_memoryfromFalsetoTrue - Added NPU device detection to disable inplace pin memory on unsupported hardware
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| checkpoint_engine/ps.py | Added manually_pinned flag to MemoryBuffer, implemented _unpin() function for manual memory unpinning, changed default for use_inplace_pin_memory to True, added NPU device check, and updated documentation |
| tests/test_reuse_pin_memory.py | New test file (renamed from test_pin_memory.py) that validates shared memory pool registration and unregistration behavior |
| tests/test_inplace_unpin.py | New test that validates repeated pin/unpin cycles work correctly without CUDA errors |
| tests/test_update.py | Removed unused variable assignment and changed directory cleanup from shutil.rmtree() to os.removedirs() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cudaErrorHostMemoryAlreadyRegisteredcudaErrorHostMemoryAlreadyRegistered
blahgeek
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #67
Manually unregister the memory pinned with
cudaHostRegisterbycudaHostUnregisterRenamed
test_pin_memory.pytotest_reuse_pin_memory.py