feat: make ParameterMeta JSON serializable#9
Merged
Conversation
weixiao-huang
force-pushed
the
feat/meta-json-serializable
branch
2 times, most recently
from
00c6716 to
00ec478
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes the ParameterMeta class JSON serializable by adding proper Pydantic validators and serializers for PyTorch types. The changes enable serialization of torch.dtype and torch.Size objects that were previously incompatible with JSON serialization.
Key changes:
- Updated Pydantic dependency to version 2.0.0+ to support new validation features
- Created custom type annotations
_TorchDtypeand_TorchSizewith validators and serializers - Replaced the arbitrary types configuration with proper type handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pyproject.toml | Updated pydantic version requirement and added requests dependency |
| checkpoint_engine/ps.py | Added custom type validators/serializers and updated ParameterMeta fields |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
weixiao-huang
force-pushed
the
feat/meta-json-serializable
branch
from
8bf9513 to
e82869c
Compare
Collaborator
|
Others, LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8