fix(shell): echo workflow slash inputs (#2052)

Co-authored-by: Will (liruifengv) <liruifeng1024@gmail.com>

Author: Miss-you

src/kimi_cli/ui/shell/__init__.py

@@ -27,7 +27,7 @@
 from kimi_cli.llm import model_display_name
 from kimi_cli.notifications import NotificationManager, NotificationWatcher
 from kimi_cli.soul import LLMNotSet, LLMNotSupported, MaxStepsReached, RunCancelled, Soul, run_soul
-from kimi_cli.soul.kimisoul import KimiSoul
+from kimi_cli.soul.kimisoul import FLOW_COMMAND_PREFIX, KimiSoul
 from kimi_cli.ui.shell import update as _update_mod
 from kimi_cli.ui.shell.console import console
 from kimi_cli.ui.shell.echo import render_user_echo_text
@@ -41,8 +41,8 @@
     toast,
 )
 from kimi_cli.ui.shell.replay import replay_recent_history
+from kimi_cli.ui.shell.slash import SKILL_COMMAND_PREFIX, shell_mode_registry
 from kimi_cli.ui.shell.slash import registry as shell_slash_registry
-from kimi_cli.ui.shell.slash import shell_mode_registry
 from kimi_cli.ui.shell.update import LATEST_VERSION_FILE, UpdateResult, do_update, semver_tuple
 from kimi_cli.ui.shell.visualize import (
     ApprovalPromptDelegate,
@@ -76,6 +76,9 @@ class _PromptEvent:
 _BG_AUTO_TRIGGER_INPUT_GRACE_S = 0.75
 """Delay background auto-trigger briefly after local prompt activity."""
 
+_VISIBLE_WORKFLOW_SLASH_PREFIXES = (SKILL_COMMAND_PREFIX, FLOW_COMMAND_PREFIX)
+"""Explicit skill/flow prefixes that should remain visible in transcript."""
+
 
 class _BackgroundCompletionWatcher:
     """Watches for background task completions and auto-triggers the agent.
@@ -256,11 +259,23 @@ def _agent_slash_command_call(user_input: UserInput) -> SlashCommandCall | None:
         return resolved_call
 
     @staticmethod
-    def _should_echo_agent_input(user_input: UserInput) -> bool:
+    def _should_echo_workflow_slash_input(user_input: UserInput) -> bool:
+        command_call = Shell._agent_slash_command_call(user_input)
+        return command_call is not None and command_call.name.startswith(
+            _VISIBLE_WORKFLOW_SLASH_PREFIXES
+        )
+
+    def _should_echo_agent_input(self, user_input: UserInput) -> bool:
         if user_input.mode != PromptMode.AGENT:
             return False
         if Shell._should_exit_input(user_input):
             return False
+        # Phase 1 policy: keep operational slash commands hidden, but show
+        # explicit `/skill:*` and `/flow:*` inputs because they represent
+        # user-visible workflow intent and otherwise vanish from transcript
+        # even when the command later fails to resolve.
+        if self._should_echo_workflow_slash_input(user_input):
+            return True
         return Shell._agent_slash_command_call(user_input) is None
 
     @staticmethod

tests/core/test_kimisoul_slash_commands.py

@@ -1,15 +1,19 @@
 from __future__ import annotations
 
 from pathlib import Path
+from unittest.mock import AsyncMock
 
+import pytest
 from kaos.path import KaosPath
 from kosong.tooling.empty import EmptyToolset
 
+import kimi_cli.soul.kimisoul as kimisoul_module
 from kimi_cli.skill import Skill
 from kimi_cli.skill.flow import Flow, FlowEdge, FlowNode
 from kimi_cli.soul.agent import Agent, Runtime
 from kimi_cli.soul.context import Context
 from kimi_cli.soul.kimisoul import KimiSoul
+from kimi_cli.utils.slashcmd import SlashCommand
 
 
 def _make_flow() -> Flow:
@@ -51,3 +55,72 @@ def test_flow_skill_registers_skill_and_flow_commands(runtime: Runtime, tmp_path
     command_names = {cmd.name for cmd in soul.available_slash_commands}
     assert "skill:flow-skill" in command_names
     assert "flow:flow-skill" in command_names
+
+
+@pytest.mark.asyncio
+async def test_skill_slash_run_does_not_auto_generate_session_title(
+    runtime: Runtime, tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    skill_dir = tmp_path / "demo-skill"
+    skill_dir.mkdir()
+    skill_dir.joinpath("SKILL.md").write_text(
+        "\n".join(
+            [
+                "---",
+                "name: demo-skill",
+                "description: Demo skill",
+                "---",
+                "",
+                "Use this skill for tests.",
+            ]
+        ),
+        encoding="utf-8",
+    )
+    runtime.skills = {
+        "demo-skill": Skill(
+            name="demo-skill",
+            description="Demo skill",
+            type="standard",
+            dir=KaosPath.unsafe_from_local_path(skill_dir),
+            skill_md_file=KaosPath.unsafe_from_local_path(skill_dir / "SKILL.md"),
+            scope="user",
+        )
+    }
+
+    agent = Agent(
+        name="Test Agent",
+        system_prompt="Test system prompt.",
+        toolset=EmptyToolset(),
+        runtime=runtime,
+    )
+    soul = KimiSoul(agent, context=Context(file_backend=tmp_path / "history.jsonl"))
+    soul._turn = AsyncMock(return_value=None)  # type: ignore[method-assign]
+    monkeypatch.setattr(kimisoul_module, "wire_send", lambda _msg: None)
+
+    await soul.run("/skill:demo-skill fix login")
+
+    assert runtime.session.state.custom_title is None
+
+
+@pytest.mark.asyncio
+async def test_flow_slash_run_does_not_auto_generate_session_title(
+    runtime: Runtime, tmp_path: Path, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    agent = Agent(
+        name="Test Agent",
+        system_prompt="Test system prompt.",
+        toolset=EmptyToolset(),
+        runtime=runtime,
+    )
+    soul = KimiSoul(agent, context=Context(file_backend=tmp_path / "history.jsonl"))
+    soul._slash_command_map["flow:demo-flow"] = SlashCommand(
+        name="flow:demo-flow",
+        description="Demo flow",
+        func=lambda *_args, **_kwargs: None,
+        aliases=[],
+    )
+    monkeypatch.setattr(kimisoul_module, "wire_send", lambda _msg: None)
+
+    await soul.run("/flow:demo-flow")
+
+    assert runtime.session.state.custom_title is None

tests/ui_and_conv/test_shell_prompt_echo.py

@@ -1,11 +1,15 @@
+from types import SimpleNamespace
+from typing import cast
+
 from kosong.message import Message
 from rich.text import Text
 
 import kimi_cli.ui.shell as shell_module
+from kimi_cli.soul import Soul
 from kimi_cli.ui.shell import Shell
 from kimi_cli.ui.shell.echo import render_user_echo
 from kimi_cli.ui.shell.prompt import PromptMode, UserInput
-from kimi_cli.utils.slashcmd import SlashCommandCall
+from kimi_cli.utils.slashcmd import SlashCommand, SlashCommandCall
 from kimi_cli.wire.types import AudioURLPart, ImageURLPart, TextPart, VideoURLPart
 
 
@@ -18,6 +22,23 @@ def _make_user_input(command: str, *, mode: PromptMode = PromptMode.AGENT) -> Us
     )
 
 
+def _noop(app: object, args: str) -> None:
+    pass
+
+
+def _make_shell(*command_names: str) -> Shell:
+    commands = [
+        SlashCommand(
+            name=name,
+            description=f"{name} command",
+            func=_noop,
+            aliases=[],
+        )
+        for name in command_names
+    ]
+    return Shell(cast(Soul, SimpleNamespace(available_slash_commands=commands)))
+
+
 def test_echo_agent_input_prints_stringified_user_message(monkeypatch) -> None:
     printed: list[Text] = []
     monkeypatch.setattr(shell_module.console, "print", lambda text: printed.append(text))
@@ -105,16 +126,48 @@ def test_render_user_echo_preserves_mixed_content_order() -> None:
 
 
 def test_should_echo_agent_input_for_plain_agent_message() -> None:
-    assert Shell._should_echo_agent_input(_make_user_input("hi")) is True
+    shell = _make_shell()
+    assert shell._should_echo_agent_input(_make_user_input("hi")) is True
+
+
+def test_should_not_echo_agent_input_for_exit_commands() -> None:
+    shell = _make_shell()
+    assert shell._should_echo_agent_input(_make_user_input("exit")) is False
+    assert shell._should_echo_agent_input(_make_user_input("/exit")) is False
+    assert shell._should_echo_agent_input(_make_user_input("/quit")) is False
+
 
+def test_should_echo_agent_input_for_skill_slash_commands() -> None:
+    shell = _make_shell("skill:demo")
+    assert shell._should_echo_agent_input(_make_user_input("/skill:demo")) is True
+    assert shell._should_echo_agent_input(_make_user_input("/skill:demo 修一下登录")) is True
 
-def test_should_not_echo_agent_input_for_exit_or_slash_commands() -> None:
-    assert Shell._should_echo_agent_input(_make_user_input("exit")) is False
-    assert Shell._should_echo_agent_input(_make_user_input("/exit")) is False
-    assert Shell._should_echo_agent_input(_make_user_input("/help")) is False
+
+def test_should_echo_unregistered_skill_like_slash_commands() -> None:
+    shell = _make_shell("skill:demo")
+    assert shell._should_echo_agent_input(_make_user_input("/skill:not-found")) is True
+
+
+def test_should_echo_flow_slash_commands() -> None:
+    shell = _make_shell("flow:demo")
+    assert shell._should_echo_agent_input(_make_user_input("/flow:demo")) is True
+    assert shell._should_echo_agent_input(_make_user_input("/flow:demo 执行一下")) is True
+
+
+def test_should_echo_unregistered_flow_like_slash_commands() -> None:
+    shell = _make_shell("flow:demo")
+    assert shell._should_echo_agent_input(_make_user_input("/flow:not-found")) is True
+
+
+def test_should_not_echo_agent_input_for_non_skill_slash_commands() -> None:
+    shell = _make_shell("skill:demo")
+    assert shell._should_echo_agent_input(_make_user_input("/help")) is False
+    assert shell._should_echo_agent_input(_make_user_input("/theme dark")) is False
+    assert shell._should_echo_agent_input(_make_user_input("/clear")) is False
 
 
 def test_hidden_slash_in_placeholder_is_not_treated_as_local_command() -> None:
+    shell = _make_shell()
     user_input = UserInput(
         mode=PromptMode.AGENT,
         command="[Pasted text #1 +3 lines]",
@@ -124,7 +177,7 @@ def test_hidden_slash_in_placeholder_is_not_treated_as_local_command() -> None:
 
     assert Shell._should_exit_input(user_input) is False
     assert Shell._agent_slash_command_call(user_input) is None
-    assert Shell._should_echo_agent_input(user_input) is True
+    assert shell._should_echo_agent_input(user_input) is True
 
 
 def test_should_exit_input_is_mode_independent_for_visible_exit_commands() -> None:
@@ -135,6 +188,7 @@ def test_should_exit_input_is_mode_independent_for_visible_exit_commands() -> No
 
 
 def test_visible_slash_command_keeps_expanded_placeholder_args() -> None:
+    shell = _make_shell()
     user_input = UserInput(
         mode=PromptMode.AGENT,
         command="/echo [Pasted text #1 +3 lines]",
@@ -147,8 +201,43 @@ def test_visible_slash_command_keeps_expanded_placeholder_args() -> None:
         args="line1\nline2\nline3",
         raw_input="/echo line1\nline2\nline3",
     )
-    assert Shell._should_echo_agent_input(user_input) is False
+    assert shell._should_echo_agent_input(user_input) is False
+
+
+def test_visible_skill_slash_command_keeps_expanded_placeholder_args_and_still_echoes() -> None:
+    shell = _make_shell("skill:demo")
+    user_input = UserInput(
+        mode=PromptMode.AGENT,
+        command="/skill:demo [Pasted text #1 +3 lines]",
+        resolved_command="/skill:demo line1\nline2\nline3",
+        content=[TextPart(text="line1\nline2\nline3")],
+    )
+
+    assert Shell._agent_slash_command_call(user_input) == SlashCommandCall(
+        name="skill:demo",
+        args="line1\nline2\nline3",
+        raw_input="/skill:demo line1\nline2\nline3",
+    )
+    assert shell._should_echo_agent_input(user_input) is True
+
+
+def test_visible_flow_slash_command_keeps_expanded_placeholder_args_and_still_echoes() -> None:
+    shell = _make_shell("flow:demo")
+    user_input = UserInput(
+        mode=PromptMode.AGENT,
+        command="/flow:demo [Pasted text #1 +3 lines]",
+        resolved_command="/flow:demo line1\nline2\nline3",
+        content=[TextPart(text="line1\nline2\nline3")],
+    )
+
+    assert Shell._agent_slash_command_call(user_input) == SlashCommandCall(
+        name="flow:demo",
+        args="line1\nline2\nline3",
+        raw_input="/flow:demo line1\nline2\nline3",
+    )
+    assert shell._should_echo_agent_input(user_input) is True
 
 
 def test_should_not_echo_non_agent_input() -> None:
-    assert Shell._should_echo_agent_input(_make_user_input("ls", mode=PromptMode.SHELL)) is False
+    shell = _make_shell()
+    assert shell._should_echo_agent_input(_make_user_input("ls", mode=PromptMode.SHELL)) is False