feat(windows): prefer pwsh over powershell.exe for Shell tool#1790
Open
scwf wants to merge 1 commit intoMoonshotAI:mainfrom
Open
feat(windows): prefer pwsh over powershell.exe for Shell tool#1790scwf wants to merge 1 commit intoMoonshotAI:mainfrom
scwf wants to merge 1 commit intoMoonshotAI:mainfrom
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Environment.detect() resolves pwsh via PATH, then default install under Program Files\PowerShell\7, then inbox System32 powershell.exe, then PATH powershell. shell_name remains Windows PowerShell so Shell and background workers keep using -command. Add tests for pwsh-from-PATH and pwsh-from-install-dir; mock shutil.which in Windows environment tests. Document in CHANGELOG (en/zh).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Environment.detect() resolves pwsh via PATH, then default install under Program Files\PowerShell\7, then inbox System32 powershell.exe, then PATH powershell. shell_name remains Windows PowerShell so Shell and background workers keep using -command.
Add tests for pwsh-from-PATH and pwsh-from-install-dir; mock shutil.which in Windows environment tests. Document in CHANGELOG (en/zh).