fix: shorten_middle output exceeds target width by ellipsis length#2492
Open
nankingjing wants to merge 1 commit into
Open
fix: shorten_middle output exceeds target width by ellipsis length#2492nankingjing wants to merge 1 commit into
nankingjing wants to merge 1 commit into
Conversation
The shorten_middle function does not account for the 3-character "..." ellipsis when computing the left and right slice widths. This causes the output to always be longer than the requested width by up to 3 characters. For very small widths (0, 1, 2), Python's floor division of negative numbers also produces misleading slice indices that give unexpected results. Fix: subtract 3 from the available width before computing half-widths, and handle the edge case where width < 3 by falling back to a plain prefix slice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
shorten_middlefunction insrc/kimi_cli/utils/string.pydoes not account for the3-character
"..."ellipsis when computing the left and right slice widths.This causes the output to always be longer than the requested
widthby up to3 characters.
Reproducer
Root cause
Line 35:
text[: width // 2] + "..." + text[-width // 2 :]"..."is not subtracted fromwidth, so the output is alwayswidth + 3characters long (forwidth >= 3).width < 3, Python's floor division of negative numbers(
-width // 2) gives unexpected slice indices (e.g.-1 // 2 == -1,-2 // 2 == -1),producing even more misleading results.
Fix
Subtract 3 from the available width before computing half-widths, and handle the
edge case where
width < 3by falling back to a plain prefix slice:Call site impact
The known caller (
src/kimi_cli/tools/__init__.py:97) useswidth=50, where thecurrent code would produce 53-character output instead of 50.
Verification
Tested locally with the same Python file: