fix(tool): prevent TypeScript files from being misidentified as video#602
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix TypeScript files (
.ts,.tsx,.mts,.cts) being misidentified as MPEG Transport Stream video files, which causedReadFileto returnVideoURLPartand triggervideo_incapability check failure.Resolves #601
Problem
Python's
mimetypes.guess_type()maps.tsextension tovideo/mp2t(MPEG Transport Stream), not TypeScript. This caused:detect_file_type("app.ts")returnskind="video"ReadFilewraps content asVideoURLPartvideo_inis not enabledSolution
Override the default mimetypes mapping by registering TypeScript extensions with
text/typescriptMIME type in_EXTRA_MIME_TYPES.Changes
src/kimi_cli/tools/file/utils.py: Add.ts,.tsx,.mts,.ctsto_EXTRA_MIME_TYPEStests/test_file_utils.py: Add test cases for TypeScript file detection