fix(tui): tighten /connect error reporting for edge cases

Two silent-failure cases in /connect could leave users without any
feedback to act on:

- Reject `--url` when its value is missing (e.g. `/connect --url` or
  `/connect --url=`). Previously the argument parser silently fell
  back to the default catalog, so a malformed flag still appeared to
  succeed but with the wrong source.
- Show an explicit error when the resolved catalog yields no providers
  with supported wire types. Previously the picker resolved with no
  selection and the command returned without any UI feedback.

Author: 7Sageer

apps/kimi-code/src/tui/kimi-tui.ts

@@ -5096,7 +5096,12 @@ export class KimiTUI {
   // (context size, capabilities) comes from the catalog, so users do not
   // hand-write it.
   private async handleConnectCommand(args: string): Promise<void> {
-    const { url, preferBuiltIn, allowBuiltInFallback } = resolveConnectCatalogRequest(args);
+    const resolution = resolveConnectCatalogRequest(args);
+    if (resolution.kind === 'error') {
+      this.showError(resolution.message);
+      return;
+    }
+    const { url, preferBuiltIn, allowBuiltInFallback } = resolution.request;
 
     let catalog: Catalog | undefined;
 
@@ -5315,6 +5320,7 @@ export class KimiTUI {
         .toSorted((a, b) => a.label.localeCompare(b.label));
 
       if (options.length === 0) {
+        this.showError('Catalog has no providers with supported wire types.');
         resolve(undefined);
         return;
       }

apps/kimi-code/src/tui/utils/connect-catalog.ts

@@ -1,6 +1,7 @@
 import { DEFAULT_CATALOG_URL } from '@moonshot-ai/kimi-code-sdk';
 
 const CATALOG_URL_FLAG_RE = /--url(?:=|\s+)(\S+)/;
+const URL_FLAG_PRESENT_RE = /(?:^|\s)--url(?=\s|=|$)/;
 const REFRESH_FLAG_RE = /(?:^|\s)--refresh(?=\s|$)/;
 const BARE_HTTP_URL_RE = /^https?:\/\/\S+$/;
 
@@ -10,24 +11,41 @@ export interface ConnectCatalogRequest {
   readonly allowBuiltInFallback: boolean;
 }
 
-export function resolveConnectCatalogRequest(args: string): ConnectCatalogRequest {
+export type ConnectCatalogResolution =
+  | { readonly kind: 'ok'; readonly request: ConnectCatalogRequest }
+  | { readonly kind: 'error'; readonly message: string };
+
+export function resolveConnectCatalogRequest(args: string): ConnectCatalogResolution {
   const trimmed = args.trim();
   const urlMatch = CATALOG_URL_FLAG_RE.exec(trimmed);
   const bareUrl = BARE_HTTP_URL_RE.test(trimmed) ? trimmed : undefined;
   const explicitUrl = urlMatch?.[1] ?? bareUrl;
 
   if (explicitUrl !== undefined) {
     return {
-      url: explicitUrl,
-      preferBuiltIn: false,
-      allowBuiltInFallback: false,
+      kind: 'ok',
+      request: {
+        url: explicitUrl,
+        preferBuiltIn: false,
+        allowBuiltInFallback: false,
+      },
+    };
+  }
+
+  if (URL_FLAG_PRESENT_RE.test(trimmed)) {
+    return {
+      kind: 'error',
+      message: '--url requires a value, e.g. /connect --url=https://example.com/catalog.json',
     };
   }
 
   const refreshRequested = REFRESH_FLAG_RE.test(trimmed);
   return {
-    url: DEFAULT_CATALOG_URL,
-    preferBuiltIn: !refreshRequested,
-    allowBuiltInFallback: true,
+    kind: 'ok',
+    request: {
+      url: DEFAULT_CATALOG_URL,
+      preferBuiltIn: !refreshRequested,
+      allowBuiltInFallback: true,
+    },
   };
 }

apps/kimi-code/test/tui/utils/connect-catalog.test.ts

@@ -13,52 +13,97 @@ import { builtInCatalogDefine } from '../../../scripts/built-in-catalog.mjs';
 describe('resolveConnectCatalogRequest', () => {
   it('prefers the built-in catalog by default and keeps online fetch as fallback', () => {
     expect(resolveConnectCatalogRequest('')).toEqual({
-      url: DEFAULT_CATALOG_URL,
-      preferBuiltIn: true,
-      allowBuiltInFallback: true,
+      kind: 'ok',
+      request: {
+        url: DEFAULT_CATALOG_URL,
+        preferBuiltIn: true,
+        allowBuiltInFallback: true,
+      },
     });
     expect(resolveConnectCatalogRequest('ignored text')).toEqual({
-      url: DEFAULT_CATALOG_URL,
-      preferBuiltIn: true,
-      allowBuiltInFallback: true,
+      kind: 'ok',
+      request: {
+        url: DEFAULT_CATALOG_URL,
+        preferBuiltIn: true,
+        allowBuiltInFallback: true,
+      },
     });
   });
 
   it('forces an online fetch when --refresh is requested', () => {
     expect(resolveConnectCatalogRequest('--refresh')).toEqual({
-      url: DEFAULT_CATALOG_URL,
-      preferBuiltIn: false,
-      allowBuiltInFallback: true,
+      kind: 'ok',
+      request: {
+        url: DEFAULT_CATALOG_URL,
+        preferBuiltIn: false,
+        allowBuiltInFallback: true,
+      },
     });
     expect(resolveConnectCatalogRequest('  --refresh  ')).toEqual({
-      url: DEFAULT_CATALOG_URL,
-      preferBuiltIn: false,
-      allowBuiltInFallback: true,
+      kind: 'ok',
+      request: {
+        url: DEFAULT_CATALOG_URL,
+        preferBuiltIn: false,
+        allowBuiltInFallback: true,
+      },
     });
   });
 
   it('treats explicit catalog URLs as authoritative and ignores --refresh on them', () => {
     expect(resolveConnectCatalogRequest('--url=https://internal.example/catalog.json')).toEqual({
-      url: 'https://internal.example/catalog.json',
-      preferBuiltIn: false,
-      allowBuiltInFallback: false,
+      kind: 'ok',
+      request: {
+        url: 'https://internal.example/catalog.json',
+        preferBuiltIn: false,
+        allowBuiltInFallback: false,
+      },
     });
     expect(resolveConnectCatalogRequest('--url https://internal.example/catalog.json')).toEqual({
-      url: 'https://internal.example/catalog.json',
-      preferBuiltIn: false,
-      allowBuiltInFallback: false,
+      kind: 'ok',
+      request: {
+        url: 'https://internal.example/catalog.json',
+        preferBuiltIn: false,
+        allowBuiltInFallback: false,
+      },
     });
     expect(resolveConnectCatalogRequest('https://internal.example/catalog.json')).toEqual({
-      url: 'https://internal.example/catalog.json',
-      preferBuiltIn: false,
-      allowBuiltInFallback: false,
+      kind: 'ok',
+      request: {
+        url: 'https://internal.example/catalog.json',
+        preferBuiltIn: false,
+        allowBuiltInFallback: false,
+      },
     });
     expect(
       resolveConnectCatalogRequest('--refresh --url=https://internal.example/catalog.json'),
     ).toEqual({
-      url: 'https://internal.example/catalog.json',
-      preferBuiltIn: false,
-      allowBuiltInFallback: false,
+      kind: 'ok',
+      request: {
+        url: 'https://internal.example/catalog.json',
+        preferBuiltIn: false,
+        allowBuiltInFallback: false,
+      },
+    });
+  });
+
+  it('rejects --url when no value is provided', () => {
+    const expectedMessage =
+      '--url requires a value, e.g. /connect --url=https://example.com/catalog.json';
+    expect(resolveConnectCatalogRequest('--url')).toEqual({
+      kind: 'error',
+      message: expectedMessage,
+    });
+    expect(resolveConnectCatalogRequest('--url=')).toEqual({
+      kind: 'error',
+      message: expectedMessage,
+    });
+    expect(resolveConnectCatalogRequest('  --url  ')).toEqual({
+      kind: 'error',
+      message: expectedMessage,
+    });
+    expect(resolveConnectCatalogRequest('--refresh --url')).toEqual({
+      kind: 'error',
+      message: expectedMessage,
     });
   });
 });