Skip to content

Commit e207f52

Browse files
authored
ci(kimi-desktop): strip Developer ID prefix from CSC_NAME (#1235)
* ci(kimi-desktop): strip Developer ID prefix from CSC_NAME electron-builder rejects the 'Developer ID Application: ' prefix in CSC_NAME; the keychain setup exports the full certificate name, so strip the prefix before passing it to electron-builder. * ci(kimi-desktop): add homepage and maintainer for linux .deb electron-builder's .deb target requires a project homepage and a package maintainer; set both so the Linux build succeeds.
1 parent 020992c commit e207f52

3 files changed

Lines changed: 12 additions & 1 deletion

File tree

.github/workflows/desktop-build.yml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,16 @@ jobs:
118118
certificate-p12: ${{ secrets.APPLE_CERTIFICATE_P12 }}
119119
certificate-password: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}
120120

121+
- name: Prepare CSC_NAME for electron-builder (macOS)
122+
if: runner.os == 'macOS' && inputs.sign-macos
123+
shell: bash
124+
run: |
125+
# electron-builder rejects the "Developer ID Application: " prefix in
126+
# CSC_NAME; strip it so the certificate matches by team name + ID.
127+
name="${APPLE_SIGNING_IDENTITY}"
128+
name="${name#Developer ID Application: }"
129+
echo "CSC_NAME=$name" >> "$GITHUB_ENV"
130+
121131
- name: Prepare notarization API key (macOS)
122132
if: runner.os == 'macOS' && inputs.sign-macos
123133
shell: bash
@@ -137,7 +147,6 @@ jobs:
137147
# API key; otherwise it builds unsigned.
138148
CSC_IDENTITY_AUTO_DISCOVERY: ${{ (runner.os == 'macOS' && inputs.sign-macos) && 'true' || 'false' }}
139149
CSC_KEYCHAIN: ${{ env.APPLE_KEYCHAIN_PATH }}
140-
CSC_NAME: ${{ env.APPLE_SIGNING_IDENTITY }}
141150
KIMI_DESKTOP_NOTARIZE: ${{ (runner.os == 'macOS' && inputs.sign-macos) && 'true' || 'false' }}
142151
APPLE_API_KEY_ID: ${{ secrets.APPLE_NOTARIZATION_KEY_ID }}
143152
APPLE_API_ISSUER: ${{ secrets.APPLE_NOTARIZATION_ISSUER_ID }}

apps/kimi-desktop/electron-builder.config.cjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,5 +63,6 @@ module.exports = {
6363
category: 'Development',
6464
target: ['AppImage', 'deb'],
6565
artifactName: 'KCD-Internal-${version}-${arch}.${ext}',
66+
maintainer: 'Moonshot AI',
6667
},
6768
};

apps/kimi-desktop/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
"license": "MIT",
66
"description": "Kimi Code desktop client — an Electron shell around the Kimi web UI.",
77
"author": "Moonshot AI",
8+
"homepage": "https://github.com/MoonshotAI/kimi-code",
89
"type": "module",
910
"main": "out/main.cjs",
1011
"scripts": {

0 commit comments

Comments
 (0)