ci(kimi-desktop): strip Developer ID prefix from CSC_NAME#1235
Merged
Conversation
electron-builder rejects the 'Developer ID Application: ' prefix in CSC_NAME; the keychain setup exports the full certificate name, so strip the prefix before passing it to electron-builder.
|
commit: |
electron-builder's .deb target requires a project homepage and a package maintainer; set both so the Linux build succeeds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the macOS signing step in the desktop-build workflow.
electron-builder rejects the 'Developer ID Application: ' prefix in CSC_NAME, but the keychain setup exports the full certificate name. Strip the prefix before passing it to electron-builder.
Without this, the macOS desktop build fails with:
Please remove prefix "Developer ID Application:" from the specified name.